Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deps scope for commit messages #95

Open
AdeAttwood opened this issue May 29, 2024 · 0 comments
Open

Add deps scope for commit messages #95

AdeAttwood opened this issue May 29, 2024 · 0 comments
Labels
bug Something isn't working
Milestone
2.x

Comments

@AdeAttwood
Copy link
Collaborator

Description

All the renovate PRs are failing because of the commit message scope. In our commit lint config we don't allow the deps scope so, all the commit messages are failing.

Expected Behaviour

Renovate can create a PR and it will pass any commit checks.

Actual Behaviour

Renovate CI is failing with the following message.

chore(deps): update dependency typescript to v5.4.5
✖ scope must be one of [core, changelog, commitgen, commitlint, release, release-semver, release-calver, git-hooks, release]



 ›   Error: Commitlint failed with errors
 ›   Code: 2
@AdeAttwood AdeAttwood added the bug Something isn't working label May 29, 2024
@AdeAttwood AdeAttwood added this to the 2.x milestone May 29, 2024
AdeAttwood added a commit that referenced this issue May 29, 2024
@AdeAttwood
ci: allow the deps scope for commits
ec41671 
Summary:

All the renovate PRs are failing because of the commit message scope. In our
commit lint config we don't allow the deps scope so, all the commit messages
are failing.

Test Plan:

This is quite hard to test ATM. I think the easiest way todo it is to merge and
see if renovate is happy

Ref: #95
@AdeAttwood AdeAttwood mentioned this issue May 29, 2024
Merged
AdeAttwood added a commit that referenced this issue Aug 19, 2024
@AdeAttwood
ci: allow the deps scope for commits
8ea1cff 
Summary:

All the renovate PRs are failing because of the commit message scope. In our
commit lint config we don't allow the deps scope so, all the commit messages
are failing.

Test Plan:

This is quite hard to test ATM. I think the easiest way todo it is to merge and
see if renovate is happy

Ref: #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.x
Development

No branches or pull requests
1 participant
@AdeAttwood