-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added retry logic for transient errors in Cloud Run V2 #17021
Open
MahmoodAbuGneam
wants to merge
11
commits into
PrefectHQ:main
Choose a base branch
from
MahmoodAbuGneam:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added retry logic for transient errors in Cloud Run V2
… comments, hopefully final fix
desertaxle
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MahmoodAbuGneam! It looks like this PR contains some changes to prefect
in addition to prefect-gcp
. Based on your description, this looks like it should only include changes to prefect-gcp
, so could you revert the changes to prefect
in this PR as they seem unrelated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Implement Retry Logic for Transient Errors in Cloud Run V2 #16448
Closes #16448
Overview
This pull request implements automatic retry logic for transient errors in
JobV2.create
within_create_job_and_wait_for_registration
for Prefect-GCP Cloud Run V2 workers. The goal is to reduce false crash alerts and improve workflow stability when transient failures (e.g., HTTP 503 errors) occur.Changes Implemented
tenacity
to handle transient failures (503, 500)._create_job_and_wait_for_registration
to usecreate_job_with_retries()
instead of callingJobV2.create
directly.Checklist
Tests
The following unit tests were added:
test_create_job_with_retries_success
: Ensures retries work and the job eventually succeeds after 2 failures.test_create_job_with_retries_non_retryable_error
: Ensures non-retryable errors (e.g., 400) fail immediately.test_create_job_with_retries_max_attempts
: Ensures retries stop after max attempts (5) for persistent 503s.test_is_transient_http_error
: Ensures only 500/503 errors trigger retries.Impact
Notes