Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sub-Community Creation API Requests Don't Always Have Icons #45

Open
1 task done
SuperMarioDaBom opened this issue Jan 2, 2025 · 0 comments
Open
1 task done
Labels
awaiting-approval Topic has not been approved or denied bug Something isn't working

Comments

@SuperMarioDaBom
Copy link
Member

SuperMarioDaBom commented Jan 2, 2025

Checked Existing

  • I have checked the repository for duplicate issues.

What happened?

After doing some experimentation with Super Smash Bros. for Wii U's online tournament mode, I found that a sub-community is created upon creating a custom tournament (akin to MK8's communities). As it is currently, the Juxt API returns a 400 error which is caused by missing icon data. Smash Bros. does not send icon data, but currently Juxt requires it as seen in the code snippet below.

const createNewCommunitySchema = z.object({
name: z.string(),
description: z.string().optional(),
icon: z.string(),
app_data: z.string().optional()
});

What did you expect to happen?

A Juxt sub-community would be created.

Steps to reproduce?

Send a POST request to /v1/communities with no icon in the multipart data.

Other relevant information. (OPTIONAL)

It seems that instead of enforcing in the schema, it might be better to just have a generic icon to supply if no icon is provided.

@SuperMarioDaBom SuperMarioDaBom added bug Something isn't working awaiting-approval Topic has not been approved or denied labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Topic has not been approved or denied bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant