Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE CHANGE: Button alignment inconsistency in cards with varying content height #321

Closed
4 tasks done
Rohinipilla opened this issue Oct 8, 2024 · 3 comments
Closed
4 tasks done

Comments

@Rohinipilla
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the code change

Problem:
I am creating a card container using divs, with each card holding content inside inner divs. However, I am facing an alignment issue where the "Book Now" buttons in the cards are not aligned at the same level, especially when the content inside the cards has different heights, as shown in the screenshot below.

Expected Behavior:
The "Book Now" buttons should be aligned horizontally at the same level for all cards, regardless of the varying content heights inside each card.

Actual Behavior:
Currently, the buttons appear at different heights based on the length of the content in each card.

image

Proposed solution

my solution is to design a div container that has inner divs each one for specific content. if the text is more than the given space then we use text overflow using CSS by placing dots at the end and the user hovers over it to display the full text. then all cards have a unique style.,which improves UI

Record

  • I agree to follow this project's Code of Conduct
  • I'm a GSSOC'24 contributor
  • I want to work on this issue
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thanks for creating the issue in BuddyTrail!
Before you start working on your PR, please make sure to:

  • ⭐ Star the repository if you haven't already.
  • Pull the latest changes to avoid any merge conflicts.
  • Attach before & after screenshots in your PR for clarity.
  • Include the issue number in your PR description for better tracking.
    Don't forget to follow @PriyaGhosal – Project Admin – for more updates!

We're excited to see your contribution as part of GSSOC Extended Edition 2024 and Hacktoberfest! 🎉
Happy open-source contributing!

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thank you for creating this issue! 🎉 Your issue will soon be reviewed by either the PA or a mentor. Please note that Level 1 is temporary and can be changed during the review. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

Copy link
Contributor

Hello @Rohinipilla! Your issue #321 has been closed. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants