Use a directory outside vendor for caching

[kghbln]

Setup

• MediaWiki | 1.39.7 (64425c7)16:12, 15 May 2024
• PHP | 7.4.33 (apache2handler)
• MariaDB | 10.5.23-MariaDB-0+deb11u1
• External Content 1.3.0

Issue

On https://sandbox.semantic-mediawiki.net/wiki/README_-_Semantic_MediaWiki I got:

 Warning: Directory /../w/vendor/ezyang/htmlpurifier/library/HTMLPurifier/DefinitionCache/Serializer not writable. in /../w/vendor/ezyang/htmlpurifier/library/HTMLPurifier/DefinitionCache/Serializer.php on line 298

The issue disappears when the directory is made writable for the webserver. For caching, a directory outside of the vendor is preferable.

Is this an upstream issue?

[malberts]

It's documented upstream:
https://github.com/ezyang/htmlpurifier/blob/d9fbef8e27f6a0848a8987a8534351de98eb0fa1/INSTALL#L265-L299

There is a documented way to change the cache directory and it can probably be done here:

ExternalContent/src/Domain/ContentRenderer/ContentPurifier.php

Lines 29 to 36 in 81b5c99

	public function __construct() {
	$config = HTMLPurifier_Config::createDefault();
	$config->set( 'HTML.Allowed', self::ALLOWED_HTML_TAGS );
	$config->set( 'Attr.AllowedFrameTargets', [ '_blank' ] ); // allow target="_blank" hrefs
	$this->purifier = new HTMLPurifier( $config );
	}

[kghbln]

It will be beneficial to tell External Content where to place the cache files via a config parameter.