Skip to content

Commit 39aab32

Browse files
committed
Clarify join requirement
1 parent 0053bb0 commit 39aab32

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/Adapters/DatabasePersistentPageIdentifiersRepo.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ public function getPersistentIds( array $pageIds ): array {
3737
$result = $this->database->newSelectQueryBuilder()
3838
->select( [ 'p.page_id', 'ppi.persistent_id' ] )
3939
->from( 'page', 'p' )
40+
// Join is necessary to exclude pages deleted from the `page` table, but not `persistent_page_ids`.
4041
->leftJoin( 'persistent_page_ids', 'ppi', 'p.page_id = ppi.page_id' )
4142
->where( [ 'p.page_id' => $pageIds ] )
4243
->orderBy( 'p.page_id' )

0 commit comments

Comments
 (0)