Fix: Update return type of read_folder#10
Open
ASR134 wants to merge 2 commits intoProgrammers-Paradise:mainfrom
Open
Fix: Update return type of read_folder#10ASR134 wants to merge 2 commits intoProgrammers-Paradise:mainfrom
ASR134 wants to merge 2 commits intoProgrammers-Paradise:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the read_folder function to return a list of DataFrames instead of concatenating them into a single DataFrame, improving clarity about the function's actual behavior.
Changes:
- Updated the docstring for
read_folderto reflect that it returns a list of DataFrames - Changed the return statement from
pd.concat(df_list, ignore_index=True)todf_list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dskit/io.py
Outdated
| """ | ||
| Loads multiple files from a folder and concatenates them. | ||
| Load multiple files from a folder and returns | ||
| a list of pandas Dataframe. |
There was a problem hiding this comment.
The word "Dataframe" should be capitalized as "DataFrames" (with capital D and F, and plural). This is the standard casing used in pandas documentation and throughout the codebase.
Suggested change
| a list of pandas Dataframe. | |
| a list of pandas DataFrames. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why this change
Impact
Related issue