-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify python version for weekly test [skip-ci] #550
modify python version for weekly test [skip-ci] #550
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
will have some other trials here to figure why same python 3.8 setting works in premerge cpu test yaml file in: cc @YanxuanLiu |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
found the root cause why in premerge cpu test, although we specified python 3.8, a bundle that requires python 3.9 works:
If having this line, it seems the system default python 3.10 works, thus CI can pass, like: https://github.com/Project-MONAI/model-zoo/actions/runs/7651709230 |
according to the above finding, @KumoLiu and I found an issue of MONAI core CI, where some places also use |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Fixes # . ### Description This PR is used to update the weekly cpu test python version. `valve_landmarks` bundle now requires python 3.9+ to use numpy 1.25.2 https://github.com/Project-MONAI/model-zoo/pull/542/files#diff-a11099ce2eebc4ce9f0721ca6674516e415d68d306ad76f1574fa0985973ff79R16 I temporarily modify yaml file to trigger the weekly test on this PR and proves that the change works and will not impact other bundles. https://github.com/Project-MONAI/model-zoo/actions/runs/7650854728 ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). --------- Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Fixes # .
Description
This PR is used to update the weekly cpu test python version.
valve_landmarks
bundle now requires python 3.9+ to use numpy 1.25.2https://github.com/Project-MONAI/model-zoo/pull/542/files#diff-a11099ce2eebc4ce9f0721ca6674516e415d68d306ad76f1574fa0985973ff79R16
I temporarily modify yaml file to trigger the weekly test on this PR and proves that the change works and will not impact other bundles.
https://github.com/Project-MONAI/model-zoo/actions/runs/7650854728
Status
Ready
Please ensure all the checkboxes:
./runtests.sh --codeformat
.version
andchangelog
inmetadata.json
if changing an existing bundle.CONTRIBUTING.md
).monai
,pytorch
andnumpy
are correct inmetadata.json
.eval_metrics
of the provided weights and TorchScript modules.large_file.yml
./home/your_name/
for"bundle_root"
).