Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify python version for weekly test [skip-ci] #550

Conversation

yiheng-wang-nv
Copy link
Collaborator

@yiheng-wang-nv yiheng-wang-nv commented Jan 25, 2024

Fixes # .

Description

This PR is used to update the weekly cpu test python version. valve_landmarks bundle now requires python 3.9+ to use numpy 1.25.2
https://github.com/Project-MONAI/model-zoo/pull/542/files#diff-a11099ce2eebc4ce9f0721ca6674516e415d68d306ad76f1574fa0985973ff79R16
I temporarily modify yaml file to trigger the weekly test on this PR and proves that the change works and will not impact other bundles.

https://github.com/Project-MONAI/model-zoo/actions/runs/7650854728

Status

Ready

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv changed the title modify python version for weekly test modify python version for weekly test [skip-ci] Jan 25, 2024
@yiheng-wang-nv
Copy link
Collaborator Author

/build

@yiheng-wang-nv yiheng-wang-nv enabled auto-merge (squash) January 25, 2024 07:20
@yiheng-wang-nv
Copy link
Collaborator Author

will have some other trials here to figure why same python 3.8 setting works in premerge cpu test yaml file in:
https://github.com/Project-MONAI/model-zoo/actions/runs/7638316721/job/20843732588

cc @YanxuanLiu

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Copy link
Collaborator Author

found the root cause why in premerge cpu test, although we specified python 3.8, a bundle that requires python 3.9 works:

rm -rf /opt/hostedtoolcache this line seems remove the prepared python 3.8
f5f80e9#diff-e86b0d56af46cea339db685fd25f72b174c3e2d07439a0c9a3f5315f1ec2d1a8R33

If having this line, it seems the system default python 3.10 works, thus CI can pass, like: https://github.com/Project-MONAI/model-zoo/actions/runs/7651709230
Without this line, CI failed, like: https://github.com/Project-MONAI/model-zoo/actions/runs/7651976256

cc @YanxuanLiu @KumoLiu

@yiheng-wang-nv
Copy link
Collaborator Author

found the root cause why in premerge cpu test, although we specified python 3.8, a bundle that requires python 3.9 works:

rm -rf /opt/hostedtoolcache this line seems remove the prepared python 3.8 f5f80e9#diff-e86b0d56af46cea339db685fd25f72b174c3e2d07439a0c9a3f5315f1ec2d1a8R33

If having this line, it seems the system default python 3.10 works, thus CI can pass, like: https://github.com/Project-MONAI/model-zoo/actions/runs/7651709230 Without this line, CI failed, like: https://github.com/Project-MONAI/model-zoo/actions/runs/7651976256

cc @YanxuanLiu @KumoLiu

according to the above finding, @KumoLiu and I found an issue of MONAI core CI, where some places also use rm -rf /opt/hostedtoolcache in the github ci to save the resources used. It may lead to:
the actual python env used to test is not what is set in the yml file. cc @wyli
Let me create a ticket in MONAI core and describe more details.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv enabled auto-merge (squash) January 25, 2024 09:46
@yiheng-wang-nv
Copy link
Collaborator Author

/build

@yiheng-wang-nv yiheng-wang-nv merged commit 772bc16 into Project-MONAI:dev Jan 25, 2024
4 checks passed
yiheng-wang-nv added a commit to yiheng-wang-nv/model-zoo that referenced this pull request Jul 29, 2024
Fixes # .

### Description
This PR is used to update the weekly cpu test python version.
`valve_landmarks` bundle now requires python 3.9+ to use numpy 1.25.2

https://github.com/Project-MONAI/model-zoo/pull/542/files#diff-a11099ce2eebc4ce9f0721ca6674516e415d68d306ad76f1574fa0985973ff79R16
I temporarily modify yaml file to trigger the weekly test on this PR and
proves that the change works and will not impact other bundles.

https://github.com/Project-MONAI/model-zoo/actions/runs/7650854728


### Status
**Ready**

### Please ensure all the checkboxes:
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Codeformat tests passed locally by running `./runtests.sh
--codeformat`.
- [ ] In-line docstrings updated.
- [ ] Update `version` and `changelog` in `metadata.json` if changing an
existing bundle.
- [ ] Please ensure the naming rules in config files meet our
requirements (please refer to: `CONTRIBUTING.md`).
- [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy`
are correct in `metadata.json`.
- [ ] Descriptions should be consistent with the content, such as
`eval_metrics` of the provided weights and TorchScript modules.
- [ ] Files larger than 25MB are excluded and replaced by providing
download links in `large_file.yml`.
- [ ] Avoid using path that contains personal information within config
files (such as use `/home/your_name/` for `"bundle_root"`).

---------

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants