Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undefined label prompt check #693

Merged
merged 25 commits into from
Oct 11, 2024
Merged

Conversation

heyufan1995
Copy link
Member

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Status

Ready/Work in progress/Hold

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

heyufan1995 and others added 15 commits August 27, 2024 16:32
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Copy link
Member

@drbeh drbeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but please bump up the model version in metadata.json. Thanks

models/vista3d/scripts/evaluator.py Show resolved Hide resolved
heyufan1995 and others added 5 commits October 10, 2024 10:20
Signed-off-by: heyufan1995 <heyufan1995@gmail.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Copy link
Collaborator

/build

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Copy link
Collaborator

/build

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv yiheng-wang-nv merged commit 9d35f9a into Project-MONAI:dev Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants