-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start of AdvancedControl refactoring to add global support + more #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t re-export older ac's, and don't overwrite __init__.py (write to an alternate file instead).
This was
linked to
issues
Oct 5, 2021
…'t re-export older ac's, and don't overwrite __init__.py (write to an alternate file instead). Write out sources.json in ca, tam, and ad subdirs.
Add skipped test checker to tools
|
Changed expected result tester to collect all errors instead of throwing an assertion error on the first one. This makes the test output even more verbose, so I also added a tool that summarizes it, showing for each solution how many scenarios and which tests are failing.
Expected results gives all errors, and tool summarizes them
Buildingintegration progress
Extract 'Low Correction?' entry from excel and return in read_xls(), although it's not written anywhere yet. Pass bound_correction up from vma extraction (
…uding bound_correction and new description field. Search for 'Low Correction?' in column Y as well as X.
The second copy of the double-counted adoption must come from ref_base_adoption, not ht, in order to match excel behavior.
Bug fix: ensure that data files have unique names. Enhancement: delete original data files.
class Scenario has shared class variables that become instance variables when overridden --- but only if you override them. If you modify them instead, you modify the class variable which then affects all other instances as well. In this case, it meant that overridden adoption parameters became permanent, and affected subsequent instantiated scenarios. Detected because walkablecities passed tests by itself, but failed when tested together with other solutions. I'm amazed that there weren't more issues. Also deleted a bunch of overrides that were just re-affirming the default value.
bug fix Scenario class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is here:
Things I need to do before we can even run the code:
Beyond that:
Other things I want to do as well:
__init__.py
into a json file, just like the adoptions and tams.