Skip to content

remove local workspace Rollup resolution work around #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thescientist13 opened this issue Nov 14, 2024 · 1 comment · Fixed by #1341
Closed

remove local workspace Rollup resolution work around #1318

thescientist13 opened this issue Nov 14, 2024 · 1 comment · Fixed by #1341
Labels
alpha.1 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers v0.31.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

Type of Change

Enhancement

Summary

When the website repo was part of the monorepo workspace, there was a need to have a work around to resolve references to @greenwood/* to the local workspace file, since it wouldn't actually be in node_modules
https://github.com/ProjectEvergreen/greenwood/blob/v0.30.1/packages/cli/src/config/rollup.config.js#L138

Details

In theory we should just be able to delete that if block and comment and all tests should continue to pass.
@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers CLI labels Nov 14, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 14, 2024
@thescientist13 thescientist13 linked a pull request Apr 19, 2025 that will close this issue
enhancement/issue 684 import meta resolve refactor part 2 #1341
Merged
11 tasks
@thescientist13
Copy link
Member Author

Sweet, this was actually fixed as part of https://github.com/ProjectEvergreen/greenwood/pull/1341/files#diff-57634df7e2b1ba3ea0031d8adc1e73230ca3c93bbecfdea7b44d00c7e100ec8b

@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in [Greenwood] Phase 11 - Burndown to 1.0 Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
alpha.1 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers v0.31.0
Projects
[Greenwood] Phase 10 - Ecosystem Compat
Status: ✅ Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

enhancement/issue 684 import meta resolve refactor part 2 ProjectEvergreen/greenwood
1 participant
@thescientist13