Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate lightMode configuration option #52

Closed
6 tasks
thescientist13 opened this issue Jun 5, 2022 · 0 comments · Fixed by #61
Closed
6 tasks

deprecate lightMode configuration option #52

thescientist13 opened this issue Jun 5, 2022 · 0 comments · Fixed by #61
Assignees
Labels
breaking documentation Improvements or additions to documentation v0.3.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Jun 5, 2022

Type of Change

  • Other (please clarify below)

Summary

Per #49 / #50 , it seems that there was a much easier solution to the problem of wanting static content in the Light DOM all along; just use innerHTML 😅

Details

I think given how using innerHTML is just standard DOM and per #50 allows each component to opt-in individually, it seems to make this configuration option irrelevant, for now at least. So should

  1. Refactor website to use innerHTML
  2. Update compiler to drop support for lightMode configuration and remove from build.js
  3. Update documentation to remove reference to lightMode
  4. Open up a discussion to capture the original intent / use case, just for posterity in case its something worth re-investigating
  5. Update README
  6. Not sure if this implicates this getInnerHTML issue at all?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking documentation Improvements or additions to documentation v0.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant