Skip to content

[bug] SIWF Error Conditions should be handled when switching between wallets #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
mattheworris opened this issue May 30, 2024 · 3 comments
Open
1 task
Assignees
Labels
bug Something isn't working

Comments

@mattheworris
Copy link
Contributor

mattheworris commented May 30, 2024

As a developer, I want to switch between identities in different wallets.

Steps to repeat the error:

  1. Create and login with a user in Talisman wallet.
  2. Sign out or otherwise reset your development system.
  3. Create and login with a user in the Polkadot wallet.
  4. Sign out or otherwise reset your development system.
  5. Attempt to login with the original Talisman wallet: observe that even though you have selected an address from Talisman, SIWF sends the signing request to the last know wallet, in this case Polkadot. The reverse is also true, whenever switching wallets, the first sign is incorrectly routed to the wrong wallet.

Acceptance Criteria

  • User can login consecutively with different wallets and not encounter any errors.
@mattheworris mattheworris added the bug Something isn't working label May 30, 2024
@JoeCap08055 JoeCap08055 changed the title SIWF Error Conditions should be handled when switching between wallets [bug] SIWF Error Conditions should be handled when switching between wallets Jun 24, 2024
@JoeCap08055
Copy link
Contributor

@mattheworris is this an SAT bug, or a SIWF bug?

@mattheworris
Copy link
Contributor Author

@mattheworris is this an SAT bug, or a SIWF bug?

I'm not sure, guessing it's SIWF, as the calls from SAT seem pretty straightforward, but I didn't fault isolate yet.

@JoeCap08055
Copy link
Contributor

I'm not able to reproduce, or else I'm not following the steps correctly. Every time I sign out/sign in, I get a signing request that corresponds to the wallet I selected.

@wilwade wilwade transferred this issue from ProjectLibertyLabs/social-app-template Aug 5, 2024
@wilwade wilwade added the v1 For SIWF Version 1 label Sep 27, 2024
@mattheworris mattheworris removed the v1 For SIWF Version 1 label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants