[Bug] Bed respawn point work too strong [Pre8]

[grechnevi]

How it should work:

When you use Magic Mirror it teleports you back to spawn.

How it does work:

1. You click on the bed and "Spawn point set!" text appears in the chat.
2. You use Magic Mirror and you are teleported to the bed.
3. You click on the bed and "Spawn point removed!" text appears in the chat.
4. You use Magic Mirror and you are teleported to the bed.

What I expected to happen:

1. You click on the bed and "Spawn point removed!" appears
2. Magic Mirror teleports you back to spawn.

[hakusaro]

Is this in reference to SSC? This may be fixed in the next pre-release (changed in commit: 836fd1d).

[grechnevi]

Yes, I used SSC while I was testing this.

[grechnevi]

Still doesn't work with Pre-release 7.

Also I can't change bed spawn points between two beds instantly, I need to wait 3-5 second.

[grechnevi]

Doesn't work with Pre8.

[hakusaro]

@AxeelAnder not sure if you have any clues for this?

[AxeelAnder]

TShock/TShockAPI/GetDataHandlers.cs

Lines 2112 to 2142 in 0730881

	if ((Main.ServerSideCharacter) && (spawnx == -1 && spawny == -1)) //this means they want to spawn to vanilla spawn
	{
	args.Player.sX = Main.spawnTileX;
	args.Player.sY = Main.spawnTileY;
	args.Player.Teleport(args.Player.sX * 16, (args.Player.sY * 16) - 48);
	TShock.Log.ConsoleDebug("GetDataHandlers / HandleSpawn force teleport 'vanilla spawn' {0}", args.Player.Name);
	}
	if ((Main.ServerSideCharacter) && (args.Player.sX > 0) && (args.Player.sY > 0) && (args.TPlayer.SpawnX > 0) && ((args.TPlayer.SpawnX != args.Player.sX) && (args.TPlayer.SpawnY != args.Player.sY)))
	{
	args.Player.sX = args.TPlayer.SpawnX;
	args.Player.sY = args.TPlayer.SpawnY;
	if (((Main.tile[args.Player.sX, args.Player.sY - 1].active() && Main.tile[args.Player.sX, args.Player.sY - 1].type == 79)) && (WorldGen.StartRoomCheck(args.Player.sX, args.Player.sY - 1)))
	{
	args.Player.Teleport(args.Player.sX * 16, (args.Player.sY * 16) - 48);
	TShock.Log.ConsoleDebug("GetDataHandlers / HandleSpawn force teleport phase 1 {0}", args.Player.Name);
	}
	}
	else if ((Main.ServerSideCharacter) && (args.Player.sX > 0) && (args.Player.sY > 0))
	{
	if (((Main.tile[args.Player.sX, args.Player.sY - 1].active() && Main.tile[args.Player.sX, args.Player.sY - 1].type == 79)) && (WorldGen.StartRoomCheck(args.Player.sX, args.Player.sY - 1)))
	{
	args.Player.Teleport(args.Player.sX * 16, (args.Player.sY * 16) - 48);
	TShock.Log.ConsoleDebug("GetDataHandlers / HandleSpawn force teleport phase 2 {0}", args.Player.Name);
	}
	}

In this case, force teleport 'vanilla spawn' and force teleport phase 1 both will be triggered, and the later overrides the former, leads to the incorrect result.

Maybe we should change this if to else if

TShock/TShockAPI/GetDataHandlers.cs

Line 2121 in 0730881

if ((Main.ServerSideCharacter) && (args.Player.sX > 0) && (args.Player.sY > 0) && (args.TPlayer.SpawnX > 0) && ((args.TPlayer.SpawnX != args.Player.sX) && (args.TPlayer.SpawnY != args.Player.sY)))

[hakusaro]

Can y'all test this? https://github.com/Pryaxis/TShock/actions/runs/117511286

[grechnevi]

Does work right and instantly with setting and removing spawn point.
Does work right and slow (a couple of seconds) with changing spawn points between beds.

[grechnevi]

I think that this slowness while changing spawn points can be abused in certain game situations.
You can still teleport to the previous bed and then after some amount of time to the last one.

Also, you can teleport between them infinitely by setting spawn point and teleporting instantly, wait some time and do the same.

[kiroushi]

Did this break the ability to set the bed as the spawn point with SSC?

DB spawnX and spawnY are not updated when right clicking and setting the spawn for me, no matter which privileges.

[hakusaro]

It's entirely possible -- if you can open an issue about this and show the actual in game behavior that'd be nice.