Merge pull request ckan#8148 from EricSoroos/search_rebuild_message

Add an error notification when rebuilding the search index for a package that can't be found

Author: wardi

changes/8148.bugfix

@@ -0,0 +1 @@
+Add error notification when rebuilding the search index via the cli when the requested package can't be found.

ckan/cli/search_index.py

@@ -48,6 +48,8 @@ def rebuild(
                 defer_commit=(not commit_each),
                 quiet=quiet and not verbose,
                 clear=clear)
+    except logic.NotFound:
+        error_shout("Couldn't find package %s" % package_id)
     except Exception as e:
         error_shout(e)
     if not commit_each:

ckan/tests/cli/test_search_index.py

@@ -172,3 +172,9 @@ def test_test_main_operations(self, cli):
         assert not result.exit_code, result.output
         search_result = helpers.call_action(u'package_search', q=u"package")
         assert search_result[u'count'] == 2
+
+    def test_rebuild_invalid_dataset(self, cli):
+        # attempt to index package that doesn't exist
+        result = cli.invoke(ckan, [u'search-index', u'rebuild', u'invalid-dataset'])
+        assert not result.exit_code, result.output
+        assert "Couldn't find" in result.output