Nos aseguramos de que safeScore sea numérico #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corregimos la ordenacion en el ranking y posiblemente otros errores que ocurran al comparar como cadenas pensando que son numeros Fix PucelaBits#189
palmerabollo
reviewed
Oct 6, 2022
| @@ -97,15 +97,15 @@ const filenameToData = (f) => ({ | |||
| .map(({ name, id }) => ({ | |||
| name, | |||
| id, | |||
| safeScore: getSafeScore(filterByTerritorioId(all, id)), | |||
| safeScore: Number(getSafeScore(filterByTerritorioId(all, id))), | |||
There was a problem hiding this comment.
Muchísimas gracias, @albfernandez. Tiene buena pinta la PR, hago alguna prueba más cuando saque un rato y la mergeo si está todo ok.
A priori creo que si getSafeScore ya devuelve un Number, no hace falta volverlo a convertir aquí y en la L108.
Suggested change
| safeScore: Number(getSafeScore(filterByTerritorioId(all, id))), | |
| safeScore: getSafeScore(filterByTerritorioId(all, id)), |
palmerabollo
reviewed
Oct 6, 2022
| subTerritories: territoriesLevel2 | ||
| .map(filenameToData) | ||
| .filter(({ file }) => id === file.comunidad) | ||
| .map(({ file, id }) => ({ id, ...file })) | ||
| .map(({ name, id }) => ({ | ||
| name, | ||
| id, | ||
| safeScore: getSafeScore(filterByTerritorioId(all, id)), | ||
| safeScore: Number(getSafeScore(filterByTerritorioId(all, id))), |
There was a problem hiding this comment.
Aquí igual, creo que basta con el cambio a Number que has hecho en el valor de retorno de la propia función
Suggested change
| safeScore: Number(getSafeScore(filterByTerritorioId(all, id))), | |
| safeScore: getSafeScore(filterByTerritorioId(all, id)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corregimos la ordenacion en el ranking y posiblemente otros errores que ocurran al comparar como cadenas pensando que son numeros
Fix #189