Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing tabulated dispersions to be added properly #100

Open
3 tasks
domna opened this issue Jan 17, 2023 · 0 comments
Open
3 tasks

Allowing tabulated dispersions to be added properly #100

domna opened this issue Jan 17, 2023 · 0 comments

Comments

@domna
Copy link
Member

domna commented Jan 17, 2023

Problem: Currently tabulated dispersions are allowed to be added together. However, they still keep their interpolated data range so requesting a dielectric function across the two dispersions raises an error. This problem partly applies to the combinations of tabulated data + dispersion function.

Solution: It could either be solved by allowing to interpolate over two tabulated datasets when they are added together or raising an error when trying to add tabular data together. For tabulated data + function I think it is reasonable to just allow the interpolation range as is and raise an error otherwise.

Tasks:

  • A cleaner error if the data is outside the interpolation range.
  • Tests
  • Default wavelength/energy range set to the whole interpolation range. Currently, this raises an error if the interpolation range is not inside the default range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant