Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chardet encoding detection #192

Closed
domna opened this issue Sep 28, 2024 · 1 comment · Fixed by #193
Closed

Add chardet encoding detection #192

domna opened this issue Sep 28, 2024 · 1 comment · Fixed by #193
Assignees
@MarJMue

Comments

@domna
Copy link
Member

domna commented Sep 28, 2024

@quentintanguy used chardet as a library to detect encoding automatically in #191.
I think it's very nice and we should also use it for the wollam and spectraray reader.
@MarJMue
Copy link
Collaborator

MarJMue commented Oct 1, 2024

I have thought the same. It could avoid a lot of problems for other languages.

@MarJMue MarJMue self-assigned this Oct 1, 2024
@MarJMue MarJMue mentioned this issue Oct 1, 2024
Merged
@MarJMue MarJMue closed this as completed Oct 2, 2024
@MarJMue MarJMue linked a pull request Oct 2, 2024 that will close this issue
Add chardet encoding detection #193
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarJMue MarJMue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add chardet encoding detection PyEllips/pyElli
2 participants
@domna @MarJMue