-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook uses *wrong* maturin executable #17
Comments
I think the build backend gets downloaded automatically by the installer so it's not persistent on your system. I suppose the import hook could also do this as an option |
Passing thought: an easier first step might be for the hook to warn (or error?) if the maturin version on the path doesn't match the requested one in the |
Yes, this is what I thought when saying that it might not be obvious. |
I think this would be a great addition! |
perhaps the version check/warning is something that would be better handled in maturin itself. What do you think @messense ? |
Bug Description
Hi!
I recently changed to an older machine and noticed that my code would not compile with the hook:
I know
--uv
option was added as ofmaturin>=1.6
, but this constraint is already specified in mypyproject.toml
:So I checked and, indeed, my global
maturin
executable was too old:and upgrading it to
>=1.6
now works.Is there a way for this hook to use the same
maturin
executable as the one from the build backend? I guess this can be hard, especially as the place where the build dependencies are installed is probably not obvious.Otherwise, I think it could be nice to include some words about this in the docs.
What do you think?
Steps to Reproduce
uv
;--detect-uv
;maturin<1.6
globally;Please provide the output of
python -m maturin_import_hook version
(or provide manually)Does
maturin develop
work when run manually for your project?The text was updated successfully, but these errors were encountered: