Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe don't run in debug builds and tests #28

Open
Frank1234 opened this issue Aug 21, 2024 · 1 comment
Open

Maybe don't run in debug builds and tests #28

Frank1234 opened this issue Aug 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Frank1234
Copy link
Collaborator

Frank1234 commented Aug 21, 2024

The data is also sent in debug (development) builds
The data is also sent in intergration tests

does that not skew the results?

if you feel this is not something to fix in the lib (because you feel it's the clients responsibility, then at least add it to the example code in the README).

@Frank1234 Frank1234 changed the title running in debug builds and tests Stop running in debug builds and tests Aug 21, 2024
@Frank1234 Frank1234 changed the title Stop running in debug builds and tests Maybe don't run in debug builds and tests Aug 22, 2024
@Frank1234 Frank1234 added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 22, 2024
@huijkman
Copy link
Member

huijkman commented Sep 5, 2024

I guess we want this so we are able to test it properly!? If that is the case I would just add it to the README.Strictly speaking you are right that they do have an impact.But I think this is not significant. Since we're talking about millions of datapoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants