Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the integration of external libraries #166

Open
Guts opened this issue Oct 14, 2020 · 1 comment · Fixed by #165
Open

Improve the integration of external libraries #166

Guts opened this issue Oct 14, 2020 · 1 comment · Fixed by #165

Comments

@Guts
Copy link
Contributor

Guts commented Oct 14, 2020

Currently

External Python packages are stored raw in the folder ext_libs in the repository, resulting in:

  • hard to track dependencies updates
  • in contradiction with the git philosophy (only 'your' code)
  • the entire packages are loaded, including useless artifacts (tests, examples, docs...) and making it much heavier than necessary
  • packages authors are not aware that their software is being used.

Proposed behavior

  • create a requirements file listing external packages and use pip to retrieve them during development and packaging workflows.
  • remove raw files from
  • move ext_libs as a subfolder of this project package resource_sharing

Deducted development workflow

  1. Clone the repository
  2. Run python -m pip install --no-deps -U -r requirements.txt -t resource_sharing\ext_libs
  3. Use the .gitignore file to exclude unwanted dod folders.

Misc: connect with dependabot to track updates

Deducted CI workflow

  1. Clone the repository
  2. Run python -m pip install --no-deps -U -r requirements.txt -t resource_sharing\ext_libs
  3. Run classical operations: lint, tests, packaging, deployment.
@Guts
Copy link
Contributor Author

Guts commented Oct 19, 2020

@havatv is possible to repoen please? it's still a WIP. Still unachieve:

  • remove raw libs
  • adapt CI and packaging workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants