Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_do_move_abs not connected? #16

Closed
mvbnano opened this issue Jan 16, 2018 · 5 comments
Closed

_do_move_abs not connected? #16

mvbnano opened this issue Jan 16, 2018 · 5 comments

Comments

@mvbnano
Copy link
Member

mvbnano commented Jan 16, 2018

On branch _pi_usb_digital_control (and likely pi_pci_digital_control) the function _do_move_abs does not appear to be called. It appears to have been written (by QMAPP devs) do be a better way of setting the scanner position, whereby you can not move out-of-bounds.

Prior to merging upstream this should be looked in to.

@mvbnano
Copy link
Member Author

mvbnano commented Jan 17, 2018

This now applies on branch dev_ntmdt_stage also.

@mvbnano
Copy link
Member Author

mvbnano commented Jan 22, 2018

This now applies on branch dev_newfocus_screws also.

@mvbnano
Copy link
Member Author

mvbnano commented Feb 14, 2018

This is now smartly implemented in ntmdt_piezo_stage.py on branch dev_ntmdt_stage. This should be used as a standard for the implementation on our other development branches.

@mvbnano
Copy link
Member Author

mvbnano commented Feb 14, 2018

Can be resolved on branch dev_newfocus_screws once issue #28 has been resolved.

@mvbnano
Copy link
Member Author

mvbnano commented Feb 14, 2018

Implemented smarter absolute movement on all dev branches excluding dev_newfocus_screws.

@MyrddynEmrys Once your constraints are loaded as per issue #28 we will implement constraint checking on that branch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant