fix: remove old iqp authentication (#1788)

* fix: remove old iqp authentication

* Update gateway/api/authentication.py

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

* add release notes

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

Author: paaragon

client/requirements-dev.txt

@@ -1,5 +1,5 @@
 coverage>=5.5
-pylint>=2.17.7
+pylint>=3.0.0
 nbqa>=1.7.1
 treon>=0.1.4
 pytest>=6.2.5

gateway/api/authentication.py

@@ -37,24 +37,17 @@ def authenticate(self, request):
 
         crn = request.META.get("HTTP_SERVICE_CRN", None)
         channel_header = request.META.get("HTTP_SERVICE_CHANNEL", None)
-        # This is to maintain backwards compatibility with previous user patterns.
-        # In qiskit-serverless <=0.24.0 , the channel input was not provided to the
-        # authenticator, but inferred from other inputs:
-        #   - IQP use case: Catalog(token=""")
-        #   - IBM cloud use case: Catalog(channel=", token="", crn="")
-
-        if channel_header is None and crn is None:
-            channel_header = Channel.IBM_QUANTUM.value
-        if channel_header is None and crn is not None:
+
+        if channel_header is None:
             channel_header = Channel.IBM_QUANTUM_PLATFORM.value
+
         try:
             channel = Channel(channel_header)
         except ValueError as error:
             logger.warning("Channel value [%s] is not valid.", channel_header)
             raise exceptions.AuthenticationFailed(
                 "The value of the channel is not correct. Verify that you are using one of these: "
-                f"{Channel.IBM_QUANTUM.value}, {Channel.IBM_CLOUD.value}, "
-                f"{Channel.IBM_QUANTUM_PLATFORM.value}"
+                f"{Channel.IBM_CLOUD.value}, {Channel.IBM_QUANTUM_PLATFORM.value}"
             ) from error
 
         # Specific logic to guarantee access to public end-points

gateway/api/domain/authentication/channel.py

@@ -9,12 +9,10 @@ class Channel(str, Enum):
     """
     Channel values for the authentication process:
     - IBM_CLOUD
-    - IBM_QUANTUM
     - IBM_QUANTUM_PLATFORM
     - LOCAL
     """
 
     IBM_CLOUD = "ibm_cloud"
-    IBM_QUANTUM = "ibm_quantum"
     IBM_QUANTUM_PLATFORM = "ibm_quantum_platform"
     LOCAL = "local"

gateway/api/services/authentication/ibm_quantum.py

@@ -13,7 +13,6 @@
 from api.services.authentication.authentication_base import AuthenticationBase
 from api.services.authentication.ibm_quantum_platform import IBMQuantumPlatform
 from api.services.authentication.local_authentication import LocalAuthenticationService
-from api.services.authentication.ibm_quantum import IBMQuantum
 from api.domain.authentication.channel import Channel
 
 
@@ -47,10 +46,6 @@ def _get_authentication_service_instance(self) -> AuthenticationBase:
             )
             return IBMQuantumPlatform(api_key=self.authorization_token, crn=self.crn)
 
-        if self.channel == Channel.IBM_QUANTUM:
-            logger.debug("Authentication will be executed with IQP.")
-            return IBMQuantum(authorization_token=self.authorization_token)
-
         logger.debug("Authentication will be executed with Local service.")
         return LocalAuthenticationService(authorization_token=self.authorization_token)
 

gateway/api/use_cases/authentication.py

@@ -161,17 +161,11 @@ def build_env_variables(  # pylint: disable=too-many-positional-arguments
             extra = {
                 "QISKIT_IBM_INSTANCE": str(instance),
             }
-        # pylint: disable=fixme
-        # TODO: remove this path once iqp classic is sunset for all users
-        if channel.value == Channel.IBM_QUANTUM.value:
-            url = "https://auth.quantum.ibm.com/api"
-        else:
-            url = settings.QISKIT_IBM_URL
         extra.update(
             {
                 "QISKIT_IBM_TOKEN": str(token),
                 "QISKIT_IBM_CHANNEL": channel.value,
-                "QISKIT_IBM_URL": url,
+                "QISKIT_IBM_URL": settings.QISKIT_IBM_URL,
             }
         )
 

gateway/api/utils.py

@@ -241,7 +241,7 @@ def run(self, request):  # pylint: disable=too-many-locals
         carrier = {}
         TraceContextTextMapPropagator().inject(carrier)
         arguments = serializer.data.get("arguments")
-        channel = Channel.IBM_QUANTUM
+        channel = Channel.IBM_QUANTUM_PLATFORM
         token = ""
         instance = None
         if request.auth: