This repository has been archived by the owner on May 17, 2024. It is now read-only.
Is it possible to ship a "MVP <UserAccountButton/>" menu item #2512
Locked
techtolentino
started this conversation in
Ideas
Replies: 1 comment
-
We can close this discussion since a "mvp" version of the User profile button is currently being implemented in Sprint 5. A PR can be seen here - Qiskit/platypus#805 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
As part of the User Account MVP designs, we could have potentially shipped with a
<UserAccountButton/>
in the main navigation menu.Today, I tried exploring the effort to add that button, with a link to the
/account
page. In this process, I ran into a few issues that I felt were worth bringing up.Giving less than a
Size - S
effort, here's a quick/incomplete prototype of this addition:Screen.Recording.2022-02-25.at.1.33.33.PM.mov
Issues worth discussing
Separations of concerns — for some reason, I think we made the
<UserAccountButton/>
(plus its submenu) dependent on the shipping of the dark-theme work. Instead, we could have shipped just the button + a submenu container that had the ability to include whatever else we wanted (appropriate links, dark-theme, language settings, etc)Consistency — we now have multiple components for our header navigation, both of which reside in their respective repositories. At one point we had planned on addressing this with the
qiskit-vue
component library, but from what I remember, that will be deprecated and we'll (at some point) adopt a web-components-based library.Summary
We're now in a dev-territory where we can't ship "an MVP version" of a
<UserAccountButton/>
, without starting the web-components project and ensuring that it works for both the qiskit.org and platypus projects. My instinct tells me that we're far off from this (unless someone's been starting this project already).My questions, finally:
<UserAccountButton/>
+ a little submenu?💭
🤔
Beta Was this translation helpful? Give feedback.
All reactions