From 6f7ecec2505911a48e939da2a1737d3a6a69bca2 Mon Sep 17 00:00:00 2001
From: Corniel Nobel <corniel@gmail.com>
Date: Wed, 23 Oct 2024 17:11:47 +0200
Subject: [PATCH] Use a hashset to prevent attributes from being added twice.

---
 .../Syntax/Attribute_decoration_specs.cs          | 15 +++++++++++++++
 .../Collections/Empty.cs                          |  3 +++
 .../Extensions/Qowaiv.CodeGeneration.TypeInfo.cs  |  7 +++++--
 .../OpenApiTypeResolver.ResolveType.cs            |  2 +-
 .../Qowaiv.CodeGeneration.OpenApi.csproj          |  2 +-
 .../Qowaiv.CodeGeneration.csproj                  |  2 +-
 src/Qowaiv.CodeGeneration/Syntax/AttributeInfo.cs |  8 ++++++++
 7 files changed, 34 insertions(+), 5 deletions(-)

diff --git a/specs/Qowaiv.CodeGeneration.Specs/Syntax/Attribute_decoration_specs.cs b/specs/Qowaiv.CodeGeneration.Specs/Syntax/Attribute_decoration_specs.cs
index de72e9c..df84581 100644
--- a/specs/Qowaiv.CodeGeneration.Specs/Syntax/Attribute_decoration_specs.cs
+++ b/specs/Qowaiv.CodeGeneration.Specs/Syntax/Attribute_decoration_specs.cs
@@ -20,3 +20,18 @@ public void parameter_sets()
             null, KeyValuePair.Create("Author", (object?)"Qowaiv"))
        .Should().HaveContent("[NUnit.Framework.Test(Author = \"Qowaiv\")]\r\n");
 }
+
+public class Equaly
+{
+    [Test]
+    public void by_value()
+    {
+        var attr = new AttributeInfo(typeof(TestAttribute),
+            null, KeyValuePair.Create("Author", (object?)"Qowaiv"));
+
+        var ottr = new AttributeInfo(typeof(TestAttribute),
+            null, KeyValuePair.Create("Author", (object?)"Qowaiv"));
+
+        attr.Equals(ottr).Should().BeTrue();
+    }
+}
diff --git a/src/Qowaiv.CodeGeneration.OpenApi/Collections/Empty.cs b/src/Qowaiv.CodeGeneration.OpenApi/Collections/Empty.cs
index 76cfb06..b0faa11 100644
--- a/src/Qowaiv.CodeGeneration.OpenApi/Collections/Empty.cs
+++ b/src/Qowaiv.CodeGeneration.OpenApi/Collections/Empty.cs
@@ -4,4 +4,7 @@ internal static class Empty
 {
     [Pure]
     public static List<T> List<T>() => [];
+
+    [Pure]
+    public static HashSet<T> HashSet<T>() => [];
 }
diff --git a/src/Qowaiv.CodeGeneration.OpenApi/Extensions/Qowaiv.CodeGeneration.TypeInfo.cs b/src/Qowaiv.CodeGeneration.OpenApi/Extensions/Qowaiv.CodeGeneration.TypeInfo.cs
index aa47b84..b5a4734 100644
--- a/src/Qowaiv.CodeGeneration.OpenApi/Extensions/Qowaiv.CodeGeneration.TypeInfo.cs
+++ b/src/Qowaiv.CodeGeneration.OpenApi/Extensions/Qowaiv.CodeGeneration.TypeInfo.cs
@@ -7,8 +7,11 @@ internal static class TypeInfoExtensions
 {
     public static void AddAttributes(this TypeInfo info, IEnumerable<AttributeInfo> attributes)
     {
-        var list = (List<AttributeInfo>)info.Attributes;
-        list.AddRange(attributes);
+        var hashset = (HashSet<AttributeInfo>)info.Attributes;
+        foreach (var attribute in attributes)
+        {
+            hashset.Add(attribute);
+        }
     }
 
     [Diagnostics.Contracts.CollectionMutation]
diff --git a/src/Qowaiv.CodeGeneration.OpenApi/OpenApiTypeResolver.ResolveType.cs b/src/Qowaiv.CodeGeneration.OpenApi/OpenApiTypeResolver.ResolveType.cs
index 25aeaa8..2a575c2 100644
--- a/src/Qowaiv.CodeGeneration.OpenApi/OpenApiTypeResolver.ResolveType.cs
+++ b/src/Qowaiv.CodeGeneration.OpenApi/OpenApiTypeResolver.ResolveType.cs
@@ -158,7 +158,7 @@ static bool IsNone(EnumerationField field)
                 IsPartial = Settings.Partial,
                 Properties = Empty.List<PropertyInfo>(),
                 DerivedTypes = Empty.List<Type>(),
-                Attributes = Empty.List<AttributeInfo>(),
+                Attributes = Empty.HashSet<AttributeInfo>(),
                 Visibility = ResolveVisibility(schema),
                 Documentation = new XmlDocumentation() { Summary = schema.Description },
             };
diff --git a/src/Qowaiv.CodeGeneration.OpenApi/Qowaiv.CodeGeneration.OpenApi.csproj b/src/Qowaiv.CodeGeneration.OpenApi/Qowaiv.CodeGeneration.OpenApi.csproj
index 58b420c..2bd870d 100644
--- a/src/Qowaiv.CodeGeneration.OpenApi/Qowaiv.CodeGeneration.OpenApi.csproj
+++ b/src/Qowaiv.CodeGeneration.OpenApi/Qowaiv.CodeGeneration.OpenApi.csproj
@@ -8,7 +8,7 @@
 
   <PropertyGroup>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <Version>0.0.1-alpha-021</Version>
+    <Version>0.0.1-alpha-022</Version>
     <PackageId>Qowaiv.CodeGeneration.OpenApi</PackageId>
     <PackageReleaseNotes>
       <![CDATA[
diff --git a/src/Qowaiv.CodeGeneration/Qowaiv.CodeGeneration.csproj b/src/Qowaiv.CodeGeneration/Qowaiv.CodeGeneration.csproj
index daf4b54..3ec0aa9 100644
--- a/src/Qowaiv.CodeGeneration/Qowaiv.CodeGeneration.csproj
+++ b/src/Qowaiv.CodeGeneration/Qowaiv.CodeGeneration.csproj
@@ -8,7 +8,7 @@
 
   <PropertyGroup>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <Version>0.0.1-alpha-021</Version>
+    <Version>0.0.1-alpha-022</Version>
     <PackageId>Qowaiv.CodeGeneration</PackageId>
     <PackageReleaseNotes>
       <![CDATA[
diff --git a/src/Qowaiv.CodeGeneration/Syntax/AttributeInfo.cs b/src/Qowaiv.CodeGeneration/Syntax/AttributeInfo.cs
index 97d26f0..5cfd1a0 100644
--- a/src/Qowaiv.CodeGeneration/Syntax/AttributeInfo.cs
+++ b/src/Qowaiv.CodeGeneration/Syntax/AttributeInfo.cs
@@ -1,3 +1,5 @@
+using DotNetProjectFile.MsBuild;
+
 namespace Qowaiv.CodeGeneration.Syntax;
 
 /// <summary>Represents an attribute decoration.</summary>
@@ -114,4 +116,10 @@ public override int GetHashCode()
 
         return hash;
     }
+
+    /// <summary>Returns true if both have the same values.</summary>
+    public static bool operator ==(AttributeInfo? l, AttributeInfo? r) => l is null ? r is null : l.Equals(r);
+
+    /// <summary>Returns false if both have the same values.</summary>
+    public static bool operator !=(AttributeInfo? l, AttributeInfo? r) => !(l == r);
 }