Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BloqadeNoisy #594

Merged
merged 9 commits into from
Oct 17, 2023
Merged

Add BloqadeNoisy #594

merged 9 commits into from
Oct 17, 2023

Conversation

benAtQuera
Copy link
Contributor

BloqadeNoisy

BloqadeNoisy is a stochastic wavefunction-based open system simulator that is based on the DifferentialEquations interface and designed to work directly with BloqadeODE.

This toolkit was designed to simulate the noise model of Aquila, and includes benchmarks and direct comparisons to the Aquila whitepaper data.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #594 (96a7740) into master (d1f32c2) will increase coverage by 0.39%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
+ Coverage   77.04%   77.44%   +0.39%     
==========================================
  Files          98      102       +4     
  Lines        4848     5058     +210     
==========================================
+ Hits         3735     3917     +182     
- Misses       1113     1141      +28     
Files Changed Coverage Δ
lib/BloqadeNoisy/src/problem.jl 82.00% <82.00%> (ø)
lib/BloqadeNoisy/src/noise_models.jl 97.29% <97.29%> (ø)
lib/BloqadeNoisy/src/BloqadeNoisy.jl 100.00% <100.00%> (ø)
lib/BloqadeNoisy/src/error_model.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Roger-luo
Copy link
Member

can you merge master so we can check if things are broken in this PR?

@Roger-luo
Copy link
Member

In order to get tests running in our CI, you need to put the package name here https://github.com/QuEraComputing/Bloqade.jl/blob/master/.github/workflows/CI.yml#L55

@fanglifl
Copy link
Collaborator

fanglifl commented Sep 5, 2023

@weinbe58 seems the PR has passed all checks. To merge the PR, anything else we need to do?
@MilanKornjacaQ and I can do a last review of the tutorial

Copy link
Member

@weinbe58 weinbe58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all looks OK, I think you can probably create better abstractions for the Aquila noise model in general which will be a bit easier to understand what is going on.

"readout":{
"single atom":{"p01":0.01,"p10":0.08}
}
}"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use Configurations.jl to generate Julia Objects instead of using JSON format explicitly?

You can look at BloqadeSchema as a reference on how to set up these objects.

Copy link
Member

@weinbe58 weinbe58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but lets please try to cluse #604 ASAP

@weinbe58 weinbe58 merged commit 46f7461 into master Oct 17, 2023
27 checks passed
@weinbe58 weinbe58 deleted the bmcdon/BloqadeNoisy branch October 17, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants