-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BloqadeNoisy #594
Add BloqadeNoisy #594
Conversation
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
==========================================
+ Coverage 77.04% 77.44% +0.39%
==========================================
Files 98 102 +4
Lines 4848 5058 +210
==========================================
+ Hits 3735 3917 +182
- Misses 1113 1141 +28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
can you merge master so we can check if things are broken in this PR? |
In order to get tests running in our CI, you need to put the package name here https://github.com/QuEraComputing/Bloqade.jl/blob/master/.github/workflows/CI.yml#L55 |
Add lib/BloqadeNoisy to CI.yml
Merging updates to pass the CI
Merging latest master
@weinbe58 seems the PR has passed all checks. To merge the PR, anything else we need to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Over all looks OK, I think you can probably create better abstractions for the Aquila noise model in general which will be a bit easier to understand what is going on.
"readout":{ | ||
"single atom":{"p01":0.01,"p10":0.08} | ||
} | ||
}""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use Configurations.jl
to generate Julia Objects instead of using JSON format explicitly?
You can look at BloqadeSchema as a reference on how to set up these objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but lets please try to cluse #604 ASAP
BloqadeNoisy
BloqadeNoisy is a stochastic wavefunction-based open system simulator that is based on the DifferentialEquations interface and designed to work directly with BloqadeODE.
This toolkit was designed to simulate the noise model of Aquila, and includes benchmarks and direct comparisons to the Aquila whitepaper data.