Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rydberg density plot #974

Closed
wants to merge 2 commits into from
Closed

Conversation

shubhusion
Copy link
Contributor

Fixes #876

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (aada63a) to head (c374447).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #974   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files         110      110           
  Lines        8129     8129           
=======================================
  Hits         7309     7309           
  Misses        820      820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbdullahKazi500
Copy link

is this plot part of the bloqade package I have not seen it @shubhusion any context from where this came from

@shubhusion
Copy link
Contributor Author

is this plot part of the bloqade package I have not seen it @shubhusion any context from where this came from

I just made it using rydberg density formula.

@Roger-luo has mentioned in the issue that basic definition and plots are not available for rydberg constant.
So i plotted this graph using the general formula of rydberg constant.

Maybe I am wrong here.

@AbdullahKazi500
Copy link

@shubhusion you need plots using bloqade not any external packages if you make use of external package that pr would be flaaged

@shubhusion
Copy link
Contributor Author

@shubhusion you need plots using bloqade not any external packages if you make use of external package that pr would be flaaged

Okay

@shubhusion shubhusion closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add more plots and explaination in line with whitepaper in tutorial examples
2 participants