[Unitary hack] Revert the long Docstring #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhusion
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 110 110
Lines 8129 8129
=======================================
Hits 7309 7309
Misses 820 820 ☔ View full report in Codecov by Sentry. |
Roger-luo
reviewed
May 30, 2024
|
Okay i will make changes. I was just following the function definition
mentioned. So that it looks uniform
…On Thu, 30 May, 2024, 23:37 Xiu-zhe (Roger) Luo, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/bloqade/builder/coupling.py
<#966 (comment)>
:
> + Raises:
+ None
if it raises None why do we need to mention it?
------------------------------
In src/bloqade/builder/coupling.py
<#966 (comment)>
:
> + Raises:
+ None
why do we have raises here?
—
Reply to this email directly, view it on GitHub
<#966 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AW6XHI6BPGUEH7PPEW6EY4TZE5TH5AVCNFSM6AAAAABIQVQHCCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBZGAYDSNZVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
johnzl-777
requested changes
May 30, 2024
There was a problem hiding this comment.
Hey @shubhusion good work! Just two things in terms of revisions, firstly could you run the linter on your PR as well as attempt to implement the cross reference I requested in the comment? Thanks!
|
@Roger-luo @johnzl-777 As per the feedback provided , I have made the necessary changes. |
shubhusion
changed the title
|
I'm good with this change; I think it can be counted as a 20 USD bounty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #954 #957
Improve Docstrings and Revert the long Docstrings