Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for JupyterLab 4.0 #119

Open
shaneknapp opened this issue Jun 13, 2023 · 8 comments
Open

support for JupyterLab 4.0 #119

shaneknapp opened this issue Jun 13, 2023 · 8 comments

Comments

@shaneknapp
Copy link

when trying to upgrade to Jupyterlab 4.0, i get the following error when trying to install the latest drawio package:

  • jupyterlab-drawio==0.9.0

- package jupyterlab-drawio-0.9.0-pyhd8ed1ab_0 requires jupyterlab >=3.0.0,<4, but none of the providers can be installed

@orboan
Copy link

orboan commented Sep 7, 2023

I also need this update to make this extension compatible with jupyterlab 4.0.

@linlol
Copy link

linlol commented Mar 14, 2024

Hi,

May I know that is drawio still active here since I can see that 4.0 support is still not yet available.

Also, would it be reviewed and accepted if 4.0 pr provided

Regards

@aa403
Copy link

aa403 commented Jun 5, 2024

Same here! 4.x support would be very useful!

@linlol
Copy link

linlol commented Jun 6, 2024

Hi @jtpio @jasongrout

May I know the plan of 4.0 support?

If community and contributors plan to work on this, we may just wait...

If pr from third-party individual are still welcomed, I am happy to work on this in June/July

If this project is totally deprecated, maybe I have got to maintain it internally and in private

@jtpio
Copy link
Member

jtpio commented Jun 6, 2024

Yes it would be nice to have compatibility with JupyterLab 4.

If pr from third-party individual are still welcomed, I am happy to work on this in June/July

That would be great, thanks!

Not sure how much effort this would require, but it could be worth looking at the extension upgrade script and other changes listed in https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script

@linlol
Copy link

linlol commented Jun 6, 2024

Yes it would be nice to have compatibility with JupyterLab 4.

If pr from third-party individual are still welcomed, I am happy to work on this in June/July

That would be great, thanks!

Not sure how much effort this would require, but it could be worth looking at the extension upgrade script and other changes listed in https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script

it could be kinda difficult I guess...

Since pyproject toml looks quite old. After implement upgrade script, there shall still be lots of work to do.

May have a try recently

@linlol
Copy link

linlol commented Jun 8, 2024

@jtpio so far there is almost nothing on pyproject toml, how about standardize it like a textbook labextension? For further maintainence?

I did similar thing on ipyaggrid internally create a minimised widget extension first, and migrate aggrid code there then

@linlol
Copy link

linlol commented Jun 9, 2024

Yes it would be nice to have compatibility with JupyterLab 4.

If pr from third-party individual are still welcomed, I am happy to work on this in June/July

That would be great, thanks!

Not sure how much effort this would require, but it could be worth looking at the extension upgrade script and other changes listed in https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script

Try to start working on this, tracked at below issue and PR

#120

#121

feel free to raise your advise here, hopefully it would not take too long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants