Optimize events & fix overdelivery

Author: Quezler

mods/se-cargo-rocket-construction-helper/control.lua

@@ -27,18 +27,18 @@ end)
 
 --
 
-local events = {
-  [defines.events.on_built_entity] = silo.on_created_entity,
-  [defines.events.on_robot_built_entity] = silo.on_created_entity,
-  [defines.events.script_raised_built] = silo.on_created_entity,
-  [defines.events.script_raised_revive] = silo.on_created_entity,
-  [defines.events.on_entity_cloned] = silo.on_created_entity,
-}
-
-for event, handler in pairs(events) do
-  script.on_event(event, handler)
+for _, event in ipairs({
+  defines.events.on_built_entity,
+  defines.events.on_robot_built_entity,
+  defines.events.script_raised_built,
+  defines.events.script_raised_revive,
+}) do
+  script.on_event(event, silo.on_created_entity, {
+    {filter = 'name', name = 'se-rocket-launch-pad'},
+  })
 end
 
+
 script.on_nth_tick(60 * 10, function()
   silo.every_10_seconds()
 end)

mods/se-cargo-rocket-construction-helper/info.json

@@ -2,7 +2,7 @@
     "name": "se-cargo-rocket-construction-helper",
     "title": "Space Exploration - cargo rocket construction helper",
     "description": "Delivers the capsule and rocket parts to the silo with construction robots.",
-    "version": "1.0.11",
+    "version": "1.0.12",
     "author": "Quezler",
     "factorio_version": "1.1",
     "dependencies": [

mods/se-cargo-rocket-construction-helper/scripts/silo.lua

@@ -11,20 +11,9 @@ function silo.init()
 
 end
 
-function silo.is_valid_cargo_rocket_silo(entity)
-  if not entity then return false end
-  if not entity.valid then return false end
-  if entity.type ~= "container" then return false end
-  if entity.name ~= "se-rocket-launch-pad" then return false end
-
-  return true
-end
-
 function silo.on_created_entity(event)
   local entity = event.created_entity or event.entity or event.destination
-  if not silo.is_valid_cargo_rocket_silo(entity) then return end
 
-  -- game.print(entity.name)
   silo.register(entity)
 end
 
@@ -65,8 +54,10 @@ function silo.random_tick(entry)
 
   --
 
-  local missing_sections = 100 - entry.combinator.get_or_create_control_behavior().get_signal(2).count -- todo: - any sections still in the container
-  local missing_capsules = 1   - entry.combinator.get_or_create_control_behavior().get_signal(3).count -- todo: - any capsules still in the container
+  local container_inventory = entry.container.get_inventory(defines.inventory.chest)
+  
+  local missing_sections = 100 - entry.combinator.get_or_create_control_behavior().get_signal(2).count - container_inventory.get_item_count('se-cargo-rocket-section')
+  local missing_capsules = 1   - entry.combinator.get_or_create_control_behavior().get_signal(3).count - container_inventory.get_item_count('se-space-capsule')
 
   if missing_sections > 0 or missing_capsules > 0 then