Test – cleanup_expired_bids Return Value and State

[Baskarayelu]

Description
Add tests for cleanup_expired_bids: returns correct count of removed bids; get_bids_for_invoice no longer includes expired; get_ranked_bids excludes them; idempotent when called again.

Requirements and context

• Achieve minimum 95% test coverage for cleanup_expired_bids
• Smart contracts only (Soroban/Rust)

Suggested execution

1. Fork the repo and create a branch
   git checkout -b test/cleanup-expired-bids-state
2. Implement changes
   • Add tests in src/test_bid.rs or test_bid_ranking
3. Test and commit
   • Run cargo test
   • Attach test output

Example commit message
test: cleanup_expired_bids return value and state

Guidelines

• Minimum 95 percent test coverage
• Clear documentation
• Timeframe: 96 hours

[drips-wave]

This issue has been added to the Stellar Wave Program and is worth 200 Points.

🧑‍💻 Interested in contributing? Apply to work on this issue on Drips Wave, earn points, and receive rewards.

Warning

Only applications submitted via the apply link above will be considered. Please do not apply by commenting on the issue or opening a PR directly.

🤠 Repo maintainers: You can manage this issue's Points and Complexity on your Maintainer Dashboard here. Please keep an eye on applications and respond quickly 💙

ℹ️ Learn more about Drips Wave

[Arowolokehinde]

@Arowolokehinde has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

can i work on this issue @Baskarayelu?
i have the expertise needed to work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Arowolokehinde to this issue.

[Escelit]

@Escelit has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

I would like to work on this issue because it aligns closely with my experience in writing thorough, state-focused tests for smart contract logic, particularly in Rust-based environments. Ensuring that cleanup_expired_bids behaves correctly across return values, state updates, and idempotency is critical for the reliability and security of a lending protocol like QuickLendX.

This task is especially important because expired bid handling directly affects ranking logic and invoice-level bid queries. By adding comprehensive tests that validate the removal count, confirm that get_bids_for_invoice and get_ranked_bids exclude expired bids, and verify idempotent behavior on repeated calls, I can help prevent subtle state inconsistencies that could impact protocol fairness and correctness.

I am also comfortable working within smart contract testing constraints (Soroban/Rust) and writing deterministic tests that simulate time progression and state transitions. My approach will focus on:

• Isolated unit tests for cleanup_expired_bids return value accuracy
• Integration-style tests covering state mutation across related query functions
• Edge cases such as no expired bids, all expired bids, and repeated invocations (idempotency)
• Clear documentation within the test files for maintainability

Additionally, I am committed to achieving the required ≥95% coverage by targeting all logical branches of the cleanup flow and validating both storage state and observable outputs. I will follow the suggested workflow (fork, branch, implement, run cargo test, and attach outputs) and ensure the tests are clean, well-documented, and aligned with the repository’s existing testing structure.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Escelit to this issue.

[Samuel1505]

I would like to work on this issue, kindly assign me

[morelucks]

@morelucks has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Hello,

I’m a smart contract and full-stack developer interested in contributing to this issue. I’m an experienced contributor on OnlyDust and participated in Drips Wave 1, with hands-on experience in Rust, Soroban, Cairo, Solidity, and TypeScript.

I’m passionate about building secure and scalable blockchain solutions, with a strong focus on writing clean, maintainable code. Based on the scope of this issue, I’m confident I can deliver a complete solution within 12 hours of assignment.

I would appreciate the opportunity to contribute and help move this forwar

ℹ️ Repo Maintainers: To accept this application, review their application or assign @morelucks to this issue.

[Emmanuelluxury]

@Emmanuelluxury has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

I’d like to work on this issue because it sits at the intersection of system design, financial logic, and secure contract architecture — areas I actively specialize in and enjoy building within. The problem requires careful handling of state transitions, precision math, and security constraints, which makes it both technically meaningful and impactful to the overall reliability of the protocol.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Emmanuelluxury to this issue.

[soomtochukwu]

@soomtochukwu has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Let me take this off your plate as usual :]

ℹ️ Repo Maintainers: To accept this application, review their application or assign @soomtochukwu to this issue.

[Agbasimere]

@Agbasimere has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Let me handle this professionally.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Agbasimere to this issue.

[gelluisaac]

@gelluisaac has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

I’m interested in tackling this! I have a strong background in smart contract development and full-stack systems, so I'm well-equipped to handle the requirements here. Could you please assign this to me?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @gelluisaac to this issue.

[rahimatonize]

@rahimatonize has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

hi maintainer,could you assign me.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @rahimatonize to this issue.

[MerlinTheWhiz]

@MerlinTheWhiz has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Can I work on this? I'll deliver ASAP

ℹ️ Repo Maintainers: To accept this application, review their application or assign @MerlinTheWhiz to this issue.