Parse error for some "verification timed out" response

[GeckoEidechse]

When receiving

it produces

Failed reading masterserver authentication response: "Encountered parse error "Invalid value."

on launcher, i.e. it fails to parse the response correctly.

Related:

NorthstarLauncher/NorthstarDLL/masterserver/masterserver.cpp

Line 1267 in da7061a

if (serverAddedJson.HasParseError())

[pg9182]

This may not be reproducible, as I haven't seen it before the case today. Either way, something is odd in the launcher code.

[GeckoEidechse]

Seems I was able to reproduce it by just running a v1.20.2-rc1 docker image without port forwarding.

[GeckoEidechse]

Can also reproduce on Windows by just running a dedi without port forwarding.

[GeckoEidechse]

Printing the buffer returned from the master server by doing something like

...
if (result == CURLcode::CURLE_OK)
{
	rapidjson_document serverAddedJson;
	spdlog::error("############################################");
	spdlog::error("{}", readBuffer.c_str());
	spdlog::error("############################################");
	serverAddedJson.Parse(readBuffer.c_str());
...

I get

...
[2024-01-04] [22:25:08] [NORTHSTAR] [info] Attempting to register the local server to the master server.
[2024-01-04] [22:25:18] [NORTHSTAR] [error] ############################################
[2024-01-04] [22:25:20] [NORTHSTAR] [error] error code: 502
[2024-01-04] [22:25:20] [NORTHSTAR] [error] ############################################
[2024-01-04] [22:25:20] [NORTHSTAR] [error] Failed reading masterserver authentication response: encountered parse error "Invalid value."
[2024-01-04] [22:25:20] [NORTHSTAR] [error] Reached max ms server registration attempts.

implying the master server does not return valid JSON?

[ASpoonPlaysGames]

cc @pg9182 i guess?

[pg9182]

Uh, you're saying it returned error code: 502 literally? Because nothing in atlas would do that... It's almost as if something is putting the http status into there.

[GeckoEidechse]

Uh, you're saying it returned error code: 502 literally?

At least that's what in that buffer here. Not sure what the easiest way is to dump the full response. Curl logging?

[GeckoEidechse]

Related: R2Northstar/Northstar#685

Basically Cloudflare ingesting its own response here