Hardpoint UI Fixes

[x3Karma]

TL;DR:

• Fix the missing overhead UI mentioned in Missing hardpoint features #42.
• Added missing pulsating UI when a hardpoint is amped and decaying.
  

Methodology:

When using SetHardpointState(CAPTURE_POINT_STATE_AMPING), the game will say that it is "CONTESTED" even though there's no enemy. The bar will still increase even though it said that its being contested.

This is replaced with an arbitrary number of 8 which removes the "CONTESTED" UI bug.

This shouldn't affect the actual contested UI from being displayed as the code checks for contested zones first before displaying amping UI.

[ASpoonPlaysGames]

Is there a chance that this is an underlying problem with sh_consts or something? Maybe we are missing another CAPTURE_POINT_STATE somehow?

[x3Karma]

Is there a chance that this is an underlying problem with sh_consts or something? Maybe we are missing another CAPTURE_POINT_STATE somehow?

Could be, otherwise I have no clue how this works. Past the number 8, every subsequent even number would put it back to normal "Amping _%" but every odd number puts it back to "CONTESTED".

Wouldn't surprise me if its just a random number since the playerHardpointID also needs a random number to remove the HUD from being displayed on your screen.

[NoCatt]

Fixes work on test server, in a all contesting situations.

[GeckoEidechse]

Merging as soon as I get a recent code review ^^

[EladNLG]

I like when the playerHardpointID is 69 :)

Anyways, took a look over everything, and it looks good - no real complaints.

We should, however, turn the SetHardpointState( hardpoint, 8 ) thing into an issue because I will not accept hacks in my Titanfall 2 Northstar mod >:(((

[EladNLG]

(gecko I forgot to remove the conversations i cannot delete them please dont hurt me)

[GeckoEidechse]

I did not test / code review PR, simply giving sign-off approval based on other reviews.

[pg9182]

Crashed when applied on 1.12 and testing with just myself in private match / cp / mp_colony02:

[22:34:11] [NATIVE SV] [info] Player pg9182 fully connected at time 5.73333
[22:34:11] [SCRIPT SV] [info] Player client script initialization complete: entity (1: player pg9182 [1])
[22:34:11] [SCRIPT SV] [info] ############################
[22:34:11] [SCRIPT SV] [info] CommandString: ClientStatus was not added via AddClientCommandCallback but is being called in CodeCallback_ClientCommand
[22:34:11] [SCRIPT SV] [info] ############################
[22:34:11] [SCRIPT SV] [info] ############################
[22:34:11] [SCRIPT SV] [info] CommandString: AllDialogueFinished was not added via AddClientCommandCallback but is being called in CodeCallback_ClientCommand
[22:34:11] [SCRIPT SV] [info] ############################
[22:34:11] [NATIVE SV] [info] Setting player "player pg9182 [1]" predicted first person proxy model to "" (class "spectator")
[22:34:11] [SCRIPT SV] [info] done waiting!
[22:34:12] [SCRIPT SV] [info] started intro!
[22:34:12] [SCRIPT SV] [info] starting dropship intro!
[22:34:12] [SCRIPT SV] [info] SCRIPT ERROR: [SERVER] Entity class "CNPC_Dropship" doesn't match required class for this index or function call
[22:34:12] [SCRIPT SV] [info]  -> player.SetPlayerNetInt( "playerHardpointID", hardpoint.hardpoint.GetHardpointID() )
[22:34:12] [SCRIPT SV] [info]
CALLSTACK
*FUNCTION [OnHardpointEntered()] gamemodes/_gamemode_cp.nut line [654]

[22:34:12] [SCRIPT SV] [info] LOCALS
[hardpoint] unknown struct
[player] ENTITY (npc_dropship [128] (NPC "npc_dropship" at <933.302 -1869.51 314.585>))
[trigger] ENTITY (trigger_capture_point trigger_hardpoint_c [203] at <1404 -1940 476>)
[this] TABLE

DIAGPRINTS

Doesn't crash before this PR.