Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag fetching #17

Closed
Alystrasz opened this issue Jan 10, 2024 · 2 comments · Fixed by #27
Closed

Tag fetching #17

Alystrasz opened this issue Jan 10, 2024 · 2 comments · Fixed by #27

Comments

@Alystrasz
Copy link
Contributor

When the verify_versions.py script fetches tags of a mod repository, it only accesses the first tag page (e.g. https://api.github.com/repos/{}/{}/tags), while tags resource is paginated (i.e. searched tag might not be on the first results page).

See #16 (comment) for pages example.

@Dinorush
Copy link
Contributor

Dinorush commented Jan 10, 2024

From what I can gather, there is indeed no way to reorder or increase the number of tags fetched. One possible alternative is to instead pull the tag from the latest release, e.g. https://api.github.com/repos/{}/{}/releases/latest. The field seems to be tag_name.

@Alystrasz
Copy link
Contributor Author

Problem with the latest endpoint is that it would stop developers from working on their mods as long as the mod validation process is not over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants