Skip to content

Commit a4be577

Browse files
committed
revert "Move httpclient configuration into the config class"
1 parent 114edc1 commit a4be577

File tree

3 files changed

+21
-20
lines changed

3 files changed

+21
-20
lines changed

buildSrc/src/main/kotlin/Versions.kt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
@Suppress("ConstPropertyName", "MemberVisibilityCanBePrivate")
22
object Versions {
3-
const val project = "1.1.3"
3+
const val project = "1.1.2"
44

55
object Plugins {
66
const val licenseReport = "2.5"
@@ -14,17 +14,17 @@ object Versions {
1414
}
1515

1616
const val java = 17
17-
const val slf4j = "2.0.13"
18-
const val confluent = "7.6.0"
19-
const val kafka = "${confluent}-ce"
17+
const val slf4j = "2.0.9"
18+
const val confluent = "7.5.0"
19+
const val kafka = "7.5.0-ce"
2020
const val avro = "1.11.3"
21-
const val jackson = "2.15.3"
22-
const val okhttp = "4.12.0"
21+
const val jackson = "2.15.2"
22+
const val okhttp = "4.11.0"
2323
const val junit = "5.10.0"
2424
const val mockito = "5.5.0"
2525
const val mockitoKotlin = "5.1.0"
2626
const val hamcrest = "2.2"
27-
const val radarSchemas = "0.8.8"
27+
const val radarSchemas = "0.8.4"
2828
const val opencsv = "5.8"
2929
const val ktor = "2.3.4"
3030
const val coroutines = "1.7.3"

radar-commons/src/main/java/org/radarbase/producer/schema/SchemaRestClient.kt

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,13 @@ package org.radarbase.producer.schema
22

33
import io.ktor.client.HttpClient
44
import io.ktor.client.call.body
5-
import io.ktor.client.plugins.auth.*
6-
import io.ktor.client.plugins.auth.providers.*
75
import io.ktor.client.plugins.contentnegotiation.ContentNegotiation
8-
import io.ktor.client.request.*
6+
import io.ktor.client.plugins.defaultRequest
7+
import io.ktor.client.request.HttpRequestBuilder
8+
import io.ktor.client.request.accept
9+
import io.ktor.client.request.request
10+
import io.ktor.client.request.setBody
11+
import io.ktor.client.request.url
912
import io.ktor.http.ContentType
1013
import io.ktor.http.HttpMethod
1114
import io.ktor.http.contentType
@@ -18,15 +21,13 @@ import kotlinx.coroutines.withContext
1821
import kotlinx.serialization.json.Json
1922
import org.apache.avro.Schema
2023
import org.radarbase.producer.rest.RestException.Companion.toRestException
21-
import org.slf4j.LoggerFactory
2224
import java.io.IOException
23-
import java.net.URI
2425
import kotlin.coroutines.CoroutineContext
2526

2627
/** REST client for Confluent schema registry. */
2728
class SchemaRestClient(
2829
httpClient: HttpClient,
29-
private val baseUrl: String,
30+
baseUrl: String,
3031
private val ioContext: CoroutineContext = Dispatchers.IO,
3132
) {
3233
private val httpClient: HttpClient = httpClient.config {
@@ -38,6 +39,10 @@ class SchemaRestClient(
3839
},
3940
)
4041
}
42+
defaultRequest {
43+
url(baseUrl)
44+
accept(ContentType.Application.Json)
45+
}
4146
}
4247

4348
suspend inline fun <reified T> request(
@@ -83,7 +88,7 @@ class SchemaRestClient(
8388
@Throws(IOException::class)
8489
suspend fun schemaGet(path: String): SchemaMetadata = request {
8590
method = HttpMethod.Get
86-
url(URI(baseUrl).resolve(path).toString())
91+
url(path)
8792
}
8893

8994
@Throws(IOException::class)
@@ -92,7 +97,7 @@ class SchemaRestClient(
9297
schema: Schema,
9398
): SchemaMetadata = request {
9499
method = HttpMethod.Post
95-
url(URI(baseUrl).resolve(path).toString())
100+
url(path)
96101
contentType(ContentType.Application.Json)
97102
setBody(SchemaMetadata(schema = schema.toString()))
98103
}
@@ -127,8 +132,4 @@ class SchemaRestClient(
127132
schemaGet("/schemas/ids/$id")
128133
.toParsedSchemaMetadata(id)
129134
.schema
130-
131-
companion object {
132-
private val logger = LoggerFactory.getLogger(SchemaRestClient::class.java)
133-
}
134135
}

radar-commons/src/main/java/org/radarbase/producer/schema/SchemaRetriever.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,8 @@ open class SchemaRetriever(config: Config) {
205205
@RadarProducerDsl
206206
class Config(
207207
val baseUrl: String,
208-
var httpClient: HttpClient? = null,
209208
) {
209+
var httpClient: HttpClient? = null
210210
var schemaTimeout: CacheConfig = DEFAULT_SCHEMA_TIMEOUT_CONFIG
211211
var ioContext: CoroutineContext = Dispatchers.IO
212212
fun httpClient(config: HttpClientConfig<*>.() -> Unit) {

0 commit comments

Comments
 (0)