Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFCoreRepository Attach Method #4

Open
JasonMWebb opened this issue Aug 5, 2020 · 2 comments
Open

EFCoreRepository Attach Method #4

JasonMWebb opened this issue Aug 5, 2020 · 2 comments
Assignees
Labels
Backlog Issues which have not yet been prioritized bug Something isn't working

Comments

@JasonMWebb
Copy link
Collaborator

Attach method needs to ensure that object graph is populated prior to attaching, otherwise it will assume it is already done and then attempt to attach which will generate errors with identity inserts, foreign keys and such. Something along the lines of Find(key) needs to be used first.

@JasonMWebb JasonMWebb added the bug Something isn't working label Aug 5, 2020
@JasonMWebb JasonMWebb added this to the 1.0.0 milestone Aug 5, 2020
@JasonMWebb JasonMWebb self-assigned this Aug 5, 2020
@JasonMWebb JasonMWebb modified the milestones: 1.0.0, 1.5 Sep 9, 2020
@JasonMWebb
Copy link
Collaborator Author

This works if you are using an active object graph but fails when detaching. In order to fix this, we need to implement the concept of key assignment which will not be going into the 1.0.0 release. Moving to 1.5 milestone for review there.

@JasonMWebb JasonMWebb modified the milestones: 1.5, 1.0.0 Mar 23, 2021
@JasonMWebb JasonMWebb added the Backlog Issues which have not yet been prioritized label Oct 30, 2021
@JasonMWebb
Copy link
Collaborator Author

We probably need to evaluate implementing our own change tracking abstractions for these types of repositories. This may fall into the Distributed architecture milestone enhancements along with what we're doing for eventing entities with this work. Keeping in backlog for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog Issues which have not yet been prioritized bug Something isn't working
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant