You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The below text originally taken from comment in #168 (review).
I think the PR is fine for now as it addresses the immediate issues with the way we run tests. Nice work! 🎉 I can see that the tests run around 4 times faster, which is a nice bonus.
A follow-up to improve the structure of the codebase for long-term maintenance can look something like this:
Repositories are the interfaces to the data store.
Services are the business logic for each of facets of functionality within Prez. They only contain business logic and interact with the data store through a repository object.
Routers are the API endpoints of Prez. They are the entrypoints to each facet of business logic of Prez and only deal with the HTTP layer. The service and repo objects are injected via FastAPI's DI.
I think by having these three layers at a minimum will allow us all to conceptually understand Prez and its implementation details a bit clearer.
Anyway, I think this can probably be followed up in a separate PR as it's more maintenance-related. If you agree with the above's proposed structure, I can create an issue and reference this PR's comment.
The text was updated successfully, but these errors were encountered:
The below text originally taken from comment in #168 (review).
I think the PR is fine for now as it addresses the immediate issues with the way we run tests. Nice work! 🎉 I can see that the tests run around 4 times faster, which is a nice bonus.
A follow-up to improve the structure of the codebase for long-term maintenance can look something like this:
I think by having these three layers at a minimum will allow us all to conceptually understand Prez and its implementation details a bit clearer.
Anyway, I think this can probably be followed up in a separate PR as it's more maintenance-related. If you agree with the above's proposed structure, I can create an issue and reference this PR's comment.
The text was updated successfully, but these errors were encountered: