Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearly identify the containing directory for every filename_* config option #160

Open
cjyetman opened this issue Sep 25, 2024 · 0 comments

Comments

@cjyetman
Copy link
Member

For all the filename_* type config options documented in https://rmi-pacta.github.io/pacta.multi.loanbook/articles/config_yml.html, we should clearly indicate the directory/path it should be found in, which currently can only be what's defined by either dir_input or dir_output (I think). Previously, it was a bit more obvious from the config option names, e.g. filename_abcd was obviously in dir_abcd, but now that we've consolidated everything into inputs and outputs we should be more clear about it in the documentation. Additionally, there are still some sub-directories that get created / are expected, e.g. outputs/matched_loanbooks, so we should be cautious to identify if certain filename_* type config options define the name of a file that actually lives in one of those sub-directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant