Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add run_pacta.R #19

Closed
jacobvjk opened this issue Apr 18, 2024 · 3 comments · Fixed by #48
Closed

feat: add run_pacta.R #19

jacobvjk opened this issue Apr 18, 2024 · 3 comments · Fixed by #48
Labels
ADO send issue to ADO feature a feature request or enhancement

Comments

@jacobvjk
Copy link
Member

jacobvjk commented Apr 18, 2024

the part that runs standard pacta in bulk for all loan books/groups

AB#11599

@jacobvjk jacobvjk added the feature a feature request or enhancement label Apr 18, 2024
@cjyetman
Copy link
Member

so if I understand correctly, this new run_pacta.R should be a hybrid of these two scripts, or?
https://github.com/RMI-PACTA/workflow.aggregate.loanbooks/blob/main/run_pacta_in_bulk.R
https://github.com/RMI-PACTA/workflow.osfi/blob/main/batch_run_pacta.R

@cjyetman cjyetman added the ADO send issue to ADO label Aug 12, 2024
@jacobvjk
Copy link
Member Author

jacobvjk commented Aug 12, 2024

the main differences are the following:

  • workflow.aggregate.loanbooks contained additional optional steps to apply the sector split and to remove inactive companies.
  • these two steps have now been moved to dedicated prepare_*.R scripts and do not have to be handled in run_pacta.R (see mural)
  • simply reading abcd_final and the matched_prioritized loanbooks will do the trick
  • workflow.aggregate.loanbooks also contains a step to add a "meta loan book". While I think this should be changed so that any type of loan book split can be returned, I think this will be a follow up task and that step can be retained for now.
  • workflow.osfi does not contain anything else that needs to be accounted for in this transfer

@cjyetman
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO send issue to ADO feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants