You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The R/get_csv_specs.R script includes a number of unexported utility functions. These functions should be extracted into their own script file or should be replaced by the equivalent functions being used by read_portfolio_csv() to avoid mis-alignment.
The text was updated successfully, but these errors were encountered:
cjyetman
changed the title
align get_csv_spec() utility functions with those used in `read_portfolio_csv
align get_csv_spec() utility functions with those used in read_portfolio_csv()Nov 26, 2022
previously, having an NA in either of the affected columns would fail,
as the `||` operator cannot cast NA to `logical()`
Will probably get clobbered when #11 gets addressed, but works in the
meantime.
---------
Co-authored-by: CJ Yetman <cyetman@rmi.org>
The
R/get_csv_specs.R
script includes a number of unexported utility functions. These functions should be extracted into their own script file or should be replaced by the equivalent functions being used byread_portfolio_csv()
to avoid mis-alignment.for example...
pacta.portfolio.import/R/get_csv_specs.R
Lines 287 to 295 in d318951
pacta.portfolio.import/R/get_csv_specs.R
Lines 323 to 336 in d318951
AB#10857
The text was updated successfully, but these errors were encountered: