Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter parsing function to parse raw parameters #23

Closed
AlexAxthelm opened this issue Jul 30, 2024 · 0 comments · Fixed by #27
Closed

Add parameter parsing function to parse raw parameters #23

AlexAxthelm opened this issue Jul 30, 2024 · 0 comments · Fixed by #27
Assignees
Labels
ADO enhancement New feature or request

Comments

@AlexAxthelm
Copy link
Collaborator

AlexAxthelm commented Jul 30, 2024

The current process in workflow.pacta (and repeated in workflow.pacta.report, and hopefully to be implemented differently in workflow.pacta.webapp) is to check the raw input parameters against a raw_params JSON schema which checks that either the full schema is valid, or it contains the required fields and an "inherit" key to allow for the inheritence machinery from parse_params().

https://github.com/RMI-PACTA/workflow.pacta/blob/b7ce70fb0c9160e95e1312cd9c8354cd846e0e05/R/run_pacta.R#L29-L60

This should introduce a function that wraps this full process correctly, so it can be consistently re-used in other packages.

Supports RMI-PACTA/workflow.pacta#77

AB#11554

@AlexAxthelm AlexAxthelm self-assigned this Jul 30, 2024
@AlexAxthelm AlexAxthelm added enhancement New feature or request ADO labels Jul 30, 2024
AlexAxthelm added a commit that referenced this issue Aug 1, 2024
reanme file to function name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant