Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept multiple input CSVs #35

Closed
AlexAxthelm opened this issue Feb 5, 2024 · 2 comments · Fixed by #96
Closed

Accept multiple input CSVs #35

AlexAxthelm opened this issue Feb 5, 2024 · 2 comments · Fixed by #96
Assignees

Comments

@AlexAxthelm
Copy link
Contributor

AlexAxthelm commented Feb 5, 2024

Expected behavior:

  • When passing multiple source CSVs in, the config JSON string should include an array of filenames.
  • when workflow.pacta recieves an array of input portfolio file names, the contents of those portfolios should be combined and aggregated into a single portfolio before further processing (PACTA treats all the contents as though they are a single portfolio)
  • Only one logical portfolio is processed (regardless of how many input files it is made of)

AB#11685

@AlexAxthelm
Copy link
Contributor Author

CC @cjyetman @jdhoffa for opinions

change in config json would god from:

{
 "portfolio_path": "input_dir/default_portfolio.csv",
}

to

{
 "portfolio_path": [
    "input_dir/default_portfolio.csv"
  ],
}

or

{
 "portfolio_path": [
    "input_dir/portfolio_1.csv",
    "input_dir/portfolio_2.csv",
    "input_dir/portfolio_3.csv"
  ],
}

@AlexAxthelm AlexAxthelm self-assigned this May 16, 2024
@jdhoffa
Copy link
Member

jdhoffa commented Aug 19, 2024

@AlexAxthelm I found this issue when reviewing some open discussions with Silicon Ally, is this still an important update?

If yes, I'll make sure to get it on the next sprint :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants