Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distro and Kernel compatibility #94

Closed
agravgaard opened this issue Jun 14, 2020 · 1 comment
Closed

Distro and Kernel compatibility #94

agravgaard opened this issue Jun 14, 2020 · 1 comment

Comments

@agravgaard
Copy link

agravgaard commented Jun 14, 2020

1: Unhandled linux distributions

DRM_VER will only be defined for a hardcoded selection of OS names.
For an OS name is not in that selection the dkms compilation will fail, i.e. the OS_NAME = "unknown" case.
However, by providing a default (e.g. in a final else condition of the dkms Makefile) would solve this for most linux distributions. A suggestion for this change is in #95 commit 8d62d90

The default would just be the same case as under some other OS names. Assuming that $(kdir) is defined and that it contains a Makefile with VERSION and PATCHLEVEL

2: 5.7+ Kernel

The above suggested change (see #95 ) allows successful dkms compile with 4.19 and 5.6 but not 5.7
Because pci_platform_rom was removed in 5.7

So I would like to request that the upstream changes for 5.7, i.e. the linked commit, would be merged into ROCk. As in #95 commit 3630276

Relevant issues and pull requests:

@kentrussell
Copy link
Contributor

This was resolved in 11f3599 drm/amdkcl: add various os support, which was back before ROCm 4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants