[AOMP] Add shellcheck annotation

This patch adds shellcheck 'disable' annotations in several places that
aren't wrong, but show up as false positives with the tool.

Author: jtb20

bin/aomp_common_vars

@@ -242,11 +242,15 @@ if [ "$AOMP_BUILD_SANITIZER" == 1 ]; then
   AOMP_ASAN_ORIGIN_RPATH="-DCMAKE_SHARED_LINKER_FLAGS='-Wl,--disable-new-dtags' -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=OFF -DCMAKE_INSTALL_RPATH=$AOMP_ASAN_ORIGIN_RPATH_LIST"
   # Please note below lines are only setup for ROCm ASan integration with AOMP.
   # Relative RUNPATH for ASAN binaries and libraries
+  # shellcheck disable=2016
   OPENMP_EXTRAS_LIB_RPATH='$ORIGIN:$ORIGIN/../../../lib/asan:$ORIGIN/../../../lib:$ORIGIN/../../../../lib/asan:$ORIGIN/../../../../lib'
+  # shellcheck disable=2016
   OPENMP_EXTRAS_EXE_RPATH='$ORIGIN/../lib/asan:$ORIGIN/../lib:$ORIGIN/../../lib/asan:$ORIGIN/../../lib:$ORIGIN/../../../lib/asan:$ORIGIN/../../../lib'
 else
   # Relative RUNPATH for non-ASAN binaries and libraries
+  # shellcheck disable=2016
   OPENMP_EXTRAS_LIB_RPATH='$ORIGIN:$ORIGIN/../lib:$ORIGIN/../../lib:$ORIGIN/../../../lib'
+  # shellcheck disable=2016
   OPENMP_EXTRAS_EXE_RPATH='$ORIGIN/../lib:$ORIGIN/../../lib:$ORIGIN/../../../lib'
 fi
 
@@ -269,10 +273,12 @@ if [ "$AOMP_BUILD_CUDA" == 1 ] ; then
    NVPTXGPUS_DEFAULT="35,37,50,52,53,60,61,62,70,72,75,80,86"
    #  Developers should override NVPTXGPUS to shorten build time.
    NVPTXGPUS=${NVPTXGPUS:-"${NVPTXGPUS_DEFAULT}"}
+   # shellcheck disable=2034
    AOMP_NVPTX_TARGET="NVPTX;"
 else
    NVPTXGPUS_DEFAULT=""
    NVPTXGPUS=""
+   # shellcheck disable=2034
    AOMP_NVPTX_TARGET=""
 fi
 
@@ -335,9 +341,11 @@ AOMP_GIT_INTERNAL_IP="git@github-ent"
 GITROC="https://github.com/ROCm"
 GITGERRIT="ssh://$USER@gerrit-git.amd.com:29418"
 GITKHRONOS="https://github.com/KhronosGroup"
+# shellcheck disable=2034
 GITHWLOC="https://github.com/open-mpi"
 GITLIGHTNINGINTERNAL="$AOMP_GIT_INTERNAL_IP:AMD-Lightning-Internal"
 GITPROJECT=$GITROCDEV
+# shellcheck disable=2034
 POWERINFER_REPO="https://github.com/SJTU-IPADS"
 if [ "$AOMP_STANDALONE_BUILD" == 1 ]; then
   AOMP_PROJECT_REPO_NAME=${AOMP_PROJECT_REPO_NAME:-llvm-project}
@@ -390,32 +398,44 @@ AOMP_PROF_REGISTER_REPO_NAME=${AOMP_PROF_REGISTER_REPO_NAME:-rocprofiler-registe
 AOMP_TRACE_REPO_NAME=${AOMP_TRACE_REPO_NAME:-roctracer}
 
 # These are test repositories
+# shellcheck disable=2034
 GITNEKBONE="https://github.com/AMDComputeLibraries"
 AOMP_NEKBONE_REPO_NAME=${AOMP_NEKBONE_REPO_NAME:-Nekbone}
 AOMP_APPS_REPO_NAME=${AOMP_APPS_REPO_NAME:-openmpapps}
+# shellcheck disable=2034
 GITOPENMPVV="https://github.com/OpenMP-Validation-and-Verification"
 AOMP_OPENMPVV_REPO_NAME=${AOMP_OPENMPVV_REPO_NAME:-OpenMP_VV}
+# shellcheck disable=2034
 GITSOLVV="https://github.com/SOLLVE"
 AOMP_SOLVV_REPO_NAME=${AOMP_SOLVV_REPO_NAME:-sollve_vv}
 AOMP_APPS_REPO_NAME=${AOMP_APPS_REPO_NAME:-openmpapps}
+# shellcheck disable=2034
 GITLLNL="https://github.com/llnl"
 AOMP_RAJA_REPO_NAME=${AOMP_RAJA_REPO_NAME:-raja}
 AOMP_RAJAPERF_REPO_NAME=${AOMP_RAJAPERF_REPO_NAME:-RAJAPerf}
+# shellcheck disable=2034
 GITKOKKOS="https://github.com/kokkos"
 AOMP_KOKKOS_REPO_NAME=${AOMP_KOKKOS_REPO_NAME:-kokkos}
 AOMP_INTERNAL_IP="gitlab1.amd.com"
+# shellcheck disable=2034
 GITINTERNAL="http://${AOMP_INTERNAL_IP}/dmcdouga"  # This will change soon
+# shellcheck disable=2034
 GITOVO="https://github.com/TApplencourt"
 AOMP_OVO_REPO_NAME=${AOMP_OVO_REPO_NAME:-OvO}
+# shellcheck disable=2034
 GITOMPTESTS="https://github.com/doru1004"
 AOMP_OMPTESTS_REPO_NAME=${AOMP_OMPTESTS_REPO_NAME:-omptests}
+# shellcheck disable=2034
 GITQMCPACK="https://github.com/QMCPACK"
 AOMP_QMCPACK_REPO_NAME=${AOMP_QMCPACK_REPO_NAME:-qmcpack}
+# shellcheck disable=2034
 GITOPENLIBM="https://github.com/JuliaMath"
 AOMP_OPENLIBM_REPO_NAME=${AOMP_OPENLIBM_REPO_NAME:-openlibm}
+# shellcheck disable=2034
 GITLLNLGOULASH="https://github.com/LLNL"
 AOMP_GOULASH_REPO_NAME=${AOMP_GOULASH_REPO_NAME:-goulash}
 AOMP_BABELSTREAM_REPO_NAME=${AOMP_BABELSTREAM_REPO_NAME:-babelstream}
+# shellcheck disable=2034
 GITUMT="https://github.com/LLNL"
 AOMP_UMT_REPO_NAME=${AOMP_UMT_REPO_NAME:-UMT}
 
@@ -448,6 +468,7 @@ fi
 # The cmake and make builds are actually done in 
 # BUILD_AOMP/build, not the actual repos. 
 BUILD_AOMP=${BUILD_AOMP:-$AOMP_REPOS}
+# shellcheck disable=2034
 BUILD_DIR=$BUILD_AOMP
 
 # Here is where we define different behaviors for STANDALONE build

bin/build_amdsmi.sh

@@ -77,6 +77,7 @@ if [ "$1" != "nocmake" ] && [ "$1" != "install" ] ; then
 
   declare -a MYCMAKEOPTS
 
+  # shellcheck disable=2016
   MYCMAKEOPTS=("$AOMP_ORIGIN_RPATH" -DCMAKE_BUILD_TYPE="$BUILDTYPE"
               -DCMAKE_INSTALL_PREFIX="$AOMP_INSTALL_DIR"
               -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON

bin/build_aomp.sh

@@ -14,6 +14,7 @@ function build_aomp_component() {
 
    if [[ $osversion =~ \"7\. ]]; then
      echo "OS version 7 found $(cat /etc/os-release)"
+     # shellcheck disable=1091
      [ -f /opt/rh/devtoolset-7/enable ] &&  . /opt/rh/devtoolset-7/enable
    elif [[ $osversion =~ \"8\. ]]; then
      echo "OS version 8 found $(cat /etc/os-release)"

bin/repeat_fprintf.sh

@@ -74,6 +74,8 @@ EOF
 function run_tests() {
    _log=stdout.log
    _rc0=0
+   # Disable warning for unused 'i' variable
+   # shellcheck disable=2034
    for i in $(seq 1 "$_iters") ; do
       if $_binary ; then
          _rc0=$(( _rc0 + 1 ))

bin/rocm_quick_check.sh

@@ -33,6 +33,8 @@ fi
 echo "Done checking for libnvidia"
 
 if [ -e ~/local/openmpi/lib/libmpi.so ]; then
+  # We don't care that the tilde isn't expanded
+  # shellcheck disable=2088
   echo "~/local/openmpi/lib/libmpi.so OK"
 elif [ -e /opt/openmpi-4.1.5/lib/libmpi.so ]; then
   echo "/opt/openmpi-4.1.5/lib/libmpi.so OK"
@@ -76,6 +78,8 @@ SYSFILECHECK=$(latest_filecheck /usr/bin)
 if [ "$SYSFILECHECK" == "" ]; then
 	SYSFILECHECK="FileCheck"
 fi
+# We don't care about non-alphanumeric filenames here.
+# shellcheck disable=2012
 AOMP=$(ls -d /opt/rocm-*/llvm | head -1)
 echo "$AOMP"
 SYSLLVM=$(ls /usr/lib | grep -m1 -e "llvm-[0-9]\+")