From ed7760e231bf0cfc6038807b7699c246150649dc Mon Sep 17 00:00:00 2001 From: saadrahim <44449863+saadrahim@users.noreply.github.com> Date: Thu, 1 Aug 2019 20:35:27 -0600 Subject: [PATCH] Using rocm-cmake for SOVERSION (#228) * Remove device generator versioning * Updating setting library SOVERSION with rocm-cmake --- library/src/CMakeLists.txt | 3 ++- library/src/device/CMakeLists.txt | 3 ++- library/src/device/generator/CMakeLists.txt | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/library/src/CMakeLists.txt b/library/src/CMakeLists.txt index cc037ac8..06e54406 100644 --- a/library/src/CMakeLists.txt +++ b/library/src/CMakeLists.txt @@ -105,7 +105,8 @@ target_include_directories( rocfft $ ) -set_target_properties( rocfft PROPERTIES VERSION ${rocfft_VERSION} SOVERSION ${rocfft_SOVERSION} CXX_EXTENSIONS NO ) +rocm_set_soversion( rocfft ${rocfft_SOVERSION} ) +set_target_properties( rocfft PROPERTIES CXX_EXTENSIONS NO ) set_target_properties( rocfft PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/staging" ) set_target_properties( rocfft PROPERTIES DEBUG_POSTFIX "-d" ) set_target_properties( rocfft PROPERTIES CXX_STANDARD 14 CXX_STANDARD_REQUIRED ON ) diff --git a/library/src/device/CMakeLists.txt b/library/src/device/CMakeLists.txt index ec1a678b..2be26be2 100644 --- a/library/src/device/CMakeLists.txt +++ b/library/src/device/CMakeLists.txt @@ -117,7 +117,8 @@ target_include_directories( rocfft-device $ ) -set_target_properties( rocfft-device PROPERTIES VERSION ${rocfft_VERSION} SOVERSION ${rocfft_SOVERSION} CXX_EXTENSIONS NO ) +rocm_set_soversion( rocfft-device ${rocfft_SOVERSION} ) +set_target_properties( rocfft-device PROPERTIES CXX_EXTENSIONS NO ) set_target_properties( rocfft-device PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/staging" ) set_target_properties( rocfft-device PROPERTIES DEBUG_POSTFIX "-d" ) set_target_properties( rocfft-device PROPERTIES CXX_STANDARD 14 CXX_STANDARD_REQUIRED ON ) diff --git a/library/src/device/generator/CMakeLists.txt b/library/src/device/generator/CMakeLists.txt index f4b4f691..65b721d6 100644 --- a/library/src/device/generator/CMakeLists.txt +++ b/library/src/device/generator/CMakeLists.txt @@ -5,7 +5,7 @@ add_executable( rocfft-kernel-generator generator.main.cpp generator.file.cpp ) target_compile_features( rocfft-kernel-generator PRIVATE cxx_static_assert cxx_nullptr cxx_auto_type ) -set_target_properties( rocfft-kernel-generator PROPERTIES VERSION ${rocfft_VERSION} CXX_EXTENSIONS NO ) +set_target_properties( rocfft-kernel-generator PROPERTIES CXX_EXTENSIONS NO ) set_target_properties( rocfft-kernel-generator PROPERTIES DEBUG_POSTFIX "-d" ) target_include_directories( rocfft-kernel-generator