Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitwise and #170

Merged
merged 13 commits into from
Aug 9, 2024
Merged

Bitwise and #170

merged 13 commits into from
Aug 9, 2024

Conversation

CharlieL7
Copy link
Contributor

@CharlieL7 CharlieL7 commented Jul 30, 2024

Implements converter for bitwise_and operators. Requires #3321 from MIGraphX to work.

@CharlieL7 CharlieL7 self-assigned this Jul 31, 2024
@CharlieL7 CharlieL7 marked this pull request as ready for review July 31, 2024 19:00
Copy link
Collaborator

@shivadbhavsar shivadbhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update jenkinsfile temporarily to run CI please

Copy link
Collaborator

@shivadbhavsar shivadbhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets wait for CI to pass and revert the jenkinsfile after. Not hitting approve for now so we dont merge by mistake before doing that, but looks ready to merge otherwise

@CharlieL7
Copy link
Contributor Author

python segementation fault with MobilnetV2 test that I cannot replicate locally. @shivadbhavsar any idea what's happening?

@shivadbhavsar
Copy link
Collaborator

python segementation fault with MobilnetV2 test that I cannot replicate locally. @shivadbhavsar any idea what's happening?

No idea. Do you have the latest migraphx develop locally? Im not seeing this in CI for other PRs that are using the release branch. Might be a bug introduced by a recent migraphx pr?

@shivadbhavsar shivadbhavsar merged commit 745e33f into master Aug 9, 2024
1 of 3 checks passed
@CharlieL7 CharlieL7 linked an issue Aug 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Op Support: aten.bitwise_and.Tensor
2 participants