Merge remote-tracking branch 'origin/main' into upstream_merge_24_10_28

Author: gshtras

vllm/config.py

@@ -17,7 +17,7 @@
                                             get_hf_image_processor_config,
                                             get_hf_text_config)
 from vllm.utils import (GiB_bytes, cuda_device_count_stateless, get_cpu_memory,
-                        print_warning_once)
+                        is_mi250, print_warning_once)
 
 if TYPE_CHECKING:
     from ray.util.placement_group import PlacementGroup
@@ -953,6 +953,12 @@ def __init__(
         self._verify_args()
         self.rank: int = 0
 
+        if is_mi250() and self.tensor_parallel_size > 1:
+            self.disable_custom_all_reduce = True
+            logger.info(
+                "Disabled the custom all-reduce kernel because it is not "
+                "working correctly on multi AMD MI250.")
+
     @property
     def use_ray(self) -> bool:
         return self.distributed_executor_backend == "ray" or (

vllm/utils.py

@@ -421,6 +421,15 @@ def reset(self):
         self._index = 0
 
 
+@lru_cache(maxsize=None)
+def is_mi250() -> bool:
+    if not is_hip() or not torch.cuda.is_available():
+        return False
+    archName = torch.cuda.get_device_properties('cuda').gcnArchName
+    return (archName is not None) and \
+        ("gfx90a" in archName)
+
+
 @lru_cache(maxsize=None)
 def get_max_shared_memory_bytes(gpu: int = 0) -> int:
     """Returns the maximum shared memory per thread block in bytes."""