Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable regression testing of TEASER output with BuildingsPy #669

Closed
marcusfuchs opened this issue Dec 4, 2020 · 4 comments
Closed

Enable regression testing of TEASER output with BuildingsPy #669

marcusfuchs opened this issue Dec 4, 2020 · 4 comments

Comments

@marcusfuchs
Copy link
Contributor

For quality control, I think it would be really useful if we could easily run all models generated from a TEASER project as regression tests. With BuildingsPy this can be achieved fairly easy. As TEASER outputs a Modelica package, all that is need for this is to add the following things to the output:

This way, BuildingsPy can directly run the simulation of all buildings as a regression test and generate reference results. Then users can always verify whether the models still give the same results.

I can suggest an implementation for this, but feedback and help is of course very welcome

@MichaMans
Copy link
Contributor

@marcusfuchs I like this addition! I may check an automated testing in the CI afterwards. 👍

@marcusfuchs
Copy link
Contributor Author

@MichaMans Yes, I think this would be perfect. We already have implemented something similar as would be needed for TEASER, so once I get around to work on this I think the effort required will not be too large. For automated testing in your CI afterwards, I also think that lbl-srg/BuildingsPy#393 will be helpful so you do not have to copy the reference results into the output directory.

marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 7, 2020
marcusfuchs added a commit to marcusfuchs/TEASER that referenced this issue Dec 30, 2020
@marcusfuchs
Copy link
Contributor Author

@MichaMans Starting to use this I noticed one error: I forgot to add the modelica_test_script template to setup.py, so when installing TEASER from GitHub with pip install --upgrade git+https://github.com/RWTH-EBC/TEASER@development the file is missing. I'll create a PR to fix this.

@marcusfuchs
Copy link
Contributor Author

@MichaMans Thanks again, this is all working as intended, so I am closing this.

MartinRaetz added a commit that referenced this issue Jun 16, 2021
* #543 changed shading g total to 1 for the use for the sunblind shading factor, added shading_max_irr and shading_g_total to record export, attention hardcode

* #543 changed sunblind parameters to be usecondition parameters

* boundary conditions are not needed any longer

* just black

* untested proposal for shading gvalue

* fix calculation of shading

* #635 should revise the setters

* Update doc strings and mark todos

* Add value for max power of ideal cooler

* Typo in doc string

* Improvements excel import

* Update air density typo

* added info to doc string conv_rad

* Improvements excel import

* revert part of a commit that accidently had these changes

* run black on exvel import

* add info

* delete blank line

* restart ci

* Revert "restart ci"

This reverts commit 6253f74.

* add document suggestions made by @MartinRaetz

* defaults to 1.0 if now windows

* More doc strings extensions

* More doc strings extensions 2

* WithProfile commit

* schedules is private attribute (doc string)

* Format

* Correct and reformulate withProfile docstrings

* Correct and reformulate withProfile docstrings

* correct "nan-dealing" and update pandas df.at to df.loc and typing error

* update pandas df.at to df.loc

* update parameter names based on MBL

* add moisture and nports to RC models

* add 0 time step to internal gains

* set columns in gains file to 4

* set humidification to false if central_ahu

* change shading default

* remove hacked moisure and nports

* Adds UseCondition for classrooms

* update aixlib model to CO2 multizone

* propagate use_c_flow and set medium with c

* make example import use co2 and moisture balance

* update thermal zone name

* delete probable clutter

* E261 at least two spaces before inline comment

* update for aixlib PR1052

* update buildings version

* Issue566weatherfile (#664)

* first changes

* weird things happening in git

* Revert "weird things happening in git"

This reverts commit 923747b.

* implement working version of weather file export

* delete trial results

* convert everything to: saving weather file at "project" level and not at building level

* Revert "Merge branch 'issue566weatherfile' into development"

This reverts commit 9e772fbff69fbce8711cf3629f0aec4eea0363c3.

* Revert "Revert "Merge branch 'issue566weatherfile' into development""

This reverts commit e376eec.

* blank lines (ci)

* run Black on project.py

* update unitTest.json -> previous weatherfile is outdated (doesnt work for AixLib Version) -> set to None(null) to use default weatherfile of Teaser

* naming

* naming

* Weather file line is to long resulting in error

* First try of IBPSA Weather file export

* fixing

* blank line end of file

* #566 fixed tab stop at end of file

* 566 raised aixlib version number to actual dev number

Co-authored-by: MichaMans <michael.mans@hotmail.com>

* Add annotation

For #669

* Write test scripts

For #669

* Add script to run unit tests

For #669

* Option to export reference results

For #669

* Remove test line

For #669

* Use runUnitTests from IBPSA

For #669

* Replace very old version

For #669

* Adjust model path in test script

For #669

* Add missing comma

For #669

* Add missing tolerance

For #669

* Fix decoding errors

For #669

* Deactivate pedantic mode

For #669

* Adjust annotation

For #669

* Change script location

* Delete stray bracket

* Add missing quotes

* Increase count

* revised project name of e3, revised and reformatted runUnitTests.py, added pytest simulaiton export

* revised formatting of aixlib_ouput.py

* added reference results for e2 and added them to the ref path of that example

* Add missing file to setup

For #669

* Adjusted the profiles to a uniform 24h-Format

* solve export problem

* #688 raised version number for master merge

* #688 raise AixLib version number + sort import section following pep8

Co-authored-by: MichaMans <michael.mans@hotmail.com>
Co-authored-by: Peter Remmen <PRemmen@eonerc.rwth-aachen.de>
Co-authored-by: Peter Remmen <PRemmen@users.noreply.github.com>
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Co-authored-by: Nicholas Long <nicholas.lee.long@gmail.com>
Co-authored-by: Nicholas Long <nicholas.long@nrel.gov>
Co-authored-by: Martin Kremer <martin.theodor.kremer@rwth-aachen.de>
Co-authored-by: Michael Mans <michael.mans@rwth-aachen.de>
Co-authored-by: Martin Kremer <48821826+KremerMartin@users.noreply.github.com>
Co-authored-by: Marcus Fuchs <m.fuchs@heatbeat.de>
Co-authored-by: Wackerbauer <dwa@eonerc.rwth-aachen.de>
Co-authored-by: David Wackerbauer <dwackerbauer@eonerc.rwth-aachen.de>
Co-authored-by: David <david.jansen1@rwth-aachen.de>
Co-authored-by: David Jansen <david.jansen@eonerc.rwth-aachen.de>
pseiwert pushed a commit that referenced this issue Feb 3, 2023
* #543 changed shading g total to 1 for the use for the sunblind shading factor, added shading_max_irr and shading_g_total to record export, attention hardcode

* #543 changed sunblind parameters to be usecondition parameters

* boundary conditions are not needed any longer

* just black

* untested proposal for shading gvalue

* fix calculation of shading

* #635 should revise the setters

* Update doc strings and mark todos

* Add value for max power of ideal cooler

* Typo in doc string

* Improvements excel import

* Update air density typo

* added info to doc string conv_rad

* Improvements excel import

* revert part of a commit that accidently had these changes

* run black on exvel import

* add info

* delete blank line

* restart ci

* Revert "restart ci"

This reverts commit 6253f74.

* add document suggestions made by @MartinRaetz

* defaults to 1.0 if now windows

* More doc strings extensions

* More doc strings extensions 2

* WithProfile commit

* schedules is private attribute (doc string)

* Format

* Correct and reformulate withProfile docstrings

* Correct and reformulate withProfile docstrings

* correct "nan-dealing" and update pandas df.at to df.loc and typing error

* update pandas df.at to df.loc

* update parameter names based on MBL

* add moisture and nports to RC models

* add 0 time step to internal gains

* set columns in gains file to 4

* set humidification to false if central_ahu

* change shading default

* remove hacked moisure and nports

* Adds UseCondition for classrooms

* update aixlib model to CO2 multizone

* propagate use_c_flow and set medium with c

* make example import use co2 and moisture balance

* update thermal zone name

* delete probable clutter

* E261 at least two spaces before inline comment

* update for aixlib PR1052

* update buildings version

* Issue566weatherfile (#664)

* first changes

* weird things happening in git

* Revert "weird things happening in git"

This reverts commit 923747b.

* implement working version of weather file export

* delete trial results

* convert everything to: saving weather file at "project" level and not at building level

* Revert "Merge branch 'issue566weatherfile' into development"

This reverts commit 9e772fbff69fbce8711cf3629f0aec4eea0363c3.

* Revert "Revert "Merge branch 'issue566weatherfile' into development""

This reverts commit e376eec.

* blank lines (ci)

* run Black on project.py

* update unitTest.json -> previous weatherfile is outdated (doesnt work for AixLib Version) -> set to None(null) to use default weatherfile of Teaser

* naming

* naming

* Weather file line is to long resulting in error

* First try of IBPSA Weather file export

* fixing

* blank line end of file

* #566 fixed tab stop at end of file

* 566 raised aixlib version number to actual dev number

Co-authored-by: MichaMans <michael.mans@hotmail.com>

* Add annotation

For #669

* Write test scripts

For #669

* Add script to run unit tests

For #669

* Option to export reference results

For #669

* Remove test line

For #669

* Use runUnitTests from IBPSA

For #669

* Replace very old version

For #669

* Adjust model path in test script

For #669

* Add missing comma

For #669

* Add missing tolerance

For #669

* Fix decoding errors

For #669

* Deactivate pedantic mode

For #669

* Adjust annotation

For #669

* Change script location

* Delete stray bracket

* Add missing quotes

* Increase count

* revised project name of e3, revised and reformatted runUnitTests.py, added pytest simulaiton export

* revised formatting of aixlib_ouput.py

* added reference results for e2 and added them to the ref path of that example

* Add missing file to setup

For #669

* Adjusted the profiles to a uniform 24h-Format

* solve export problem

* #688 raised version number for master merge

* #688 raise AixLib version number + sort import section following pep8

Co-authored-by: MichaMans <michael.mans@hotmail.com>
Co-authored-by: Peter Remmen <PRemmen@eonerc.rwth-aachen.de>
Co-authored-by: Peter Remmen <PRemmen@users.noreply.github.com>
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Co-authored-by: Nicholas Long <nicholas.lee.long@gmail.com>
Co-authored-by: Nicholas Long <nicholas.long@nrel.gov>
Co-authored-by: Martin Kremer <martin.theodor.kremer@rwth-aachen.de>
Co-authored-by: Michael Mans <michael.mans@rwth-aachen.de>
Co-authored-by: Martin Kremer <48821826+KremerMartin@users.noreply.github.com>
Co-authored-by: Marcus Fuchs <m.fuchs@heatbeat.de>
Co-authored-by: Wackerbauer <dwa@eonerc.rwth-aachen.de>
Co-authored-by: David Wackerbauer <dwackerbauer@eonerc.rwth-aachen.de>
Co-authored-by: David <david.jansen1@rwth-aachen.de>
Co-authored-by: David Jansen <david.jansen@eonerc.rwth-aachen.de>
pseiwert pushed a commit that referenced this issue Feb 3, 2023
* #543 changed shading g total to 1 for the use for the sunblind shading factor, added shading_max_irr and shading_g_total to record export, attention hardcode

* #543 changed sunblind parameters to be usecondition parameters

* boundary conditions are not needed any longer

* just black

* untested proposal for shading gvalue

* fix calculation of shading

* #635 should revise the setters

* Update doc strings and mark todos

* Add value for max power of ideal cooler

* Typo in doc string

* Improvements excel import

* Update air density typo

* added info to doc string conv_rad

* Improvements excel import

* revert part of a commit that accidently had these changes

* run black on exvel import

* add info

* delete blank line

* restart ci

* Revert "restart ci"

This reverts commit 6253f74.

* add document suggestions made by @MartinRaetz

* defaults to 1.0 if now windows

* More doc strings extensions

* More doc strings extensions 2

* WithProfile commit

* schedules is private attribute (doc string)

* Format

* Correct and reformulate withProfile docstrings

* Correct and reformulate withProfile docstrings

* correct "nan-dealing" and update pandas df.at to df.loc and typing error

* update pandas df.at to df.loc

* update parameter names based on MBL

* add moisture and nports to RC models

* add 0 time step to internal gains

* set columns in gains file to 4

* set humidification to false if central_ahu

* change shading default

* remove hacked moisure and nports

* Adds UseCondition for classrooms

* update aixlib model to CO2 multizone

* propagate use_c_flow and set medium with c

* make example import use co2 and moisture balance

* update thermal zone name

* delete probable clutter

* E261 at least two spaces before inline comment

* update for aixlib PR1052

* update buildings version

* Issue566weatherfile (#664)

* first changes

* weird things happening in git

* Revert "weird things happening in git"

This reverts commit 923747b.

* implement working version of weather file export

* delete trial results

* convert everything to: saving weather file at "project" level and not at building level

* Revert "Merge branch 'issue566weatherfile' into development"

This reverts commit 9e772fbff69fbce8711cf3629f0aec4eea0363c3.

* Revert "Revert "Merge branch 'issue566weatherfile' into development""

This reverts commit e376eec.

* blank lines (ci)

* run Black on project.py

* update unitTest.json -> previous weatherfile is outdated (doesnt work for AixLib Version) -> set to None(null) to use default weatherfile of Teaser

* naming

* naming

* Weather file line is to long resulting in error

* First try of IBPSA Weather file export

* fixing

* blank line end of file

* #566 fixed tab stop at end of file

* 566 raised aixlib version number to actual dev number

Co-authored-by: MichaMans <michael.mans@hotmail.com>

* Add annotation

For #669

* Write test scripts

For #669

* Add script to run unit tests

For #669

* Option to export reference results

For #669

* Remove test line

For #669

* Use runUnitTests from IBPSA

For #669

* Replace very old version

For #669

* Adjust model path in test script

For #669

* Add missing comma

For #669

* Add missing tolerance

For #669

* Fix decoding errors

For #669

* Deactivate pedantic mode

For #669

* Adjust annotation

For #669

* Change script location

* Delete stray bracket

* Add missing quotes

* Increase count

* revised project name of e3, revised and reformatted runUnitTests.py, added pytest simulaiton export

* revised formatting of aixlib_ouput.py

* added reference results for e2 and added them to the ref path of that example

* Add missing file to setup

For #669

* Adjusted the profiles to a uniform 24h-Format

* solve export problem

* #688 raised version number for master merge

* #688 raise AixLib version number + sort import section following pep8

Co-authored-by: MichaMans <michael.mans@hotmail.com>
Co-authored-by: Peter Remmen <PRemmen@eonerc.rwth-aachen.de>
Co-authored-by: Peter Remmen <PRemmen@users.noreply.github.com>
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Co-authored-by: Nicholas Long <nicholas.lee.long@gmail.com>
Co-authored-by: Nicholas Long <nicholas.long@nrel.gov>
Co-authored-by: Martin Kremer <martin.theodor.kremer@rwth-aachen.de>
Co-authored-by: Michael Mans <michael.mans@rwth-aachen.de>
Co-authored-by: Martin Kremer <48821826+KremerMartin@users.noreply.github.com>
Co-authored-by: Marcus Fuchs <m.fuchs@heatbeat.de>
Co-authored-by: Wackerbauer <dwa@eonerc.rwth-aachen.de>
Co-authored-by: David Wackerbauer <dwackerbauer@eonerc.rwth-aachen.de>
Co-authored-by: David <david.jansen1@rwth-aachen.de>
Co-authored-by: David Jansen <david.jansen@eonerc.rwth-aachen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants