Skip to content

Commit 7571df0

Browse files
committed
fix: typing in workbench component
1 parent 9fb3cbe commit 7571df0

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

frontend/components/Workbench.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
useReactFlow
1111
} from "@xyflow/react"
1212
import { PlayArrow, Widgets, Save, Delete } from "@mui/icons-material"
13+
import type { ComputeBlock } from "./nodes/ComputeBlockNode"
1314
import ComputeBlockNode from "./nodes/ComputeBlockNode"
1415
import "@xyflow/react/dist/style.css"
1516
import LoadingAndError from "./LoadingAndError"
@@ -40,12 +41,13 @@ export default function Workbench() {
4041

4142
useEffect(() => {
4243
if (projectDetails) {
43-
setNodes(projectDetails as FlowNode<Node>[]) // Ensure projectDetails matches the Node type
44+
// TODO: Fix this type workaround below (mega ugly)
45+
setNodes(projectDetails as unknown as FlowNode<Node>[])
4446
}
4547
}, [projectDetails])
4648

4749
const onNodesChange = useCallback(
48-
(changes: NodeChange[]) => setNodes((nds) => applyNodeChanges(changes, nds)),
50+
(changes: NodeChange[]) => setNodes((nds) => applyNodeChanges(changes, nds) as FlowNode<Node>[]),
4951
[]
5052
)
5153

@@ -79,6 +81,7 @@ export default function Workbench() {
7981
id: `${type}_${nodes.length + 1}`,
8082
type: "computeBlock",
8183
position,
84+
// @ts-expect-error label is somehow not recognized here from the type: maybe fix: FlowNode<Node<ComputeBlock>>
8285
data: { label: `${type} Node` },
8386
}
8487

@@ -142,7 +145,8 @@ export default function Workbench() {
142145
nodes={nodes}
143146
onNodesChange={onNodesChange}
144147
fitView
145-
onNodeClick={(_, node) => setSelectedComputeBlock(node.data)}
148+
// TODO: fix the ugly type workaround
149+
onNodeClick={(_, node) => setSelectedComputeBlock(node.data as unknown as ComputeBlock)}
146150
onPaneClick={() => setSelectedComputeBlock(undefined)}
147151
onDragOver={onDragOver}
148152
onDrop={onDrop}

0 commit comments

Comments
 (0)