Unable to save custom device height as whole number.

[brianwlynch]

Describe the bug

When adding a custom device, it won't let you save the height as a whole integer, only as X.5.

Expected behaviour

I add a device, set the height as 2RU and it saves.

Steps to reproduce

1. Add a device
2. Set device height to a whole number
3. Click Add

Browser

Rackula v0.8.4 on Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/145.0.0.0 Safari/537.36

Operating System

TrueNAS Scale - 25.10.1 - Goldeye

Additional context

No response

[brianwlynch]

The issue was caused by the height input using the browser’s default step value of 1, while MIN_DEVICE_HEIGHT is set to 0.5.

With min=0.5 and the default step=1, the browser only considered values like 0.5, 1.5, 2.5, ... valid and rejected whole integers such as 1, 2, etc.
I fixed this by explicitly setting:
step={MIN_DEVICE_HEIGHT} on the height field in AddDeviceForm.svelte.

src\lib\components\AddDeviceForm.svelte (Starting line number 214)

<input
  type="number"
  id="device-height"
  class="input-field"
  bind:value={height}
  min={MIN_DEVICE_HEIGHT}
  max={MAX_DEVICE_HEIGHT}
  class:error={heightError}
  step="{MIN_DEVICE_HEIGHT}"
/>

This allows valid values like:
0.5
1.0
1.5
2.0
etc.

while still respecting the configured min/max constraints.

[ggfevans]

Thanks for submitting this, @brianwlynch ! looks like a pretty silly bug, will fix this for next release.